Skip to content

Commit 0edc592

Browse files
authored
Fix: timezone-related test failures in JsonNormalizerTest (#83) (#84)
* Replace hardcoded timezone values with dynamic computation based on system timezone * Update testSQLTime to use time.toLocalTime().format(DateTimeFormatter.ISO_LOCAL_TIME) * Update testSQLTimeStamp to use dateTime.toLocalDateTime().format(DateTimeFormatter.ISO_LOCAL_DATE_TIME) * Update Calendar and GregorianCalendar tests to use input.toInstant().toString() * Add missing DateTimeFormatter import for time formatting
1 parent 92da0e7 commit 0edc592

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

src/test/java/dev/toonformat/jtoon/normalizer/JsonNormalizerTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.time.ZoneId;
3131
import java.time.ZoneOffset;
3232
import java.time.ZonedDateTime;
33+
import java.time.format.DateTimeFormatter;
3334
import java.util.Calendar;
3435
import java.util.Collection;
3536
import java.util.Date;
@@ -345,7 +346,8 @@ void testSQLTime() {
345346
java.sql.Time time = new java.sql.Time(1766419274);
346347
JsonNode result = JsonNormalizer.normalize(time);
347348
assertTrue(result.isString());
348-
assertEquals("11:40:19", result.asString());
349+
String expected = time.toLocalTime().format(DateTimeFormatter.ISO_LOCAL_TIME);
350+
assertEquals(expected, result.asString());
349351
}
350352

351353
@Test
@@ -354,7 +356,8 @@ void testSQLTimeStamp() {
354356
java.sql.Timestamp dateTime = new java.sql.Timestamp(1766419274);
355357
JsonNode result = JsonNormalizer.normalize(dateTime);
356358
assertTrue(result.isString());
357-
assertEquals("1970-01-21T11:40:19.274", result.asString());
359+
String expected = dateTime.toLocalDateTime().format(DateTimeFormatter.ISO_LOCAL_DATE_TIME);
360+
assertEquals(expected, result.asString());
358361
}
359362

360363

@@ -1191,7 +1194,8 @@ void givenCalendar_whenTryNormalizeTemporal_thenIsoStringNode() throws Exception
11911194

11921195
// Then
11931196
assertInstanceOf(StringNode.class, result);
1194-
assertEquals("2017-02-16T19:22:28Z", ((JsonNode) result).asString());
1197+
String expected = input.toInstant().toString();
1198+
assertEquals(expected, ((JsonNode) result).asString());
11951199
}
11961200

11971201
@Test
@@ -1205,7 +1209,8 @@ void givenGregorianCalendar_whenTryNormalizeTemporal_thenIsoStringNode() throws
12051209

12061210
// Then
12071211
assertInstanceOf(StringNode.class, result);
1208-
assertEquals("2017-02-16T19:22:28Z", ((JsonNode) result).asString());
1212+
String expected = input.toInstant().toString();
1213+
assertEquals(expected, ((JsonNode) result).asString());
12091214
}
12101215

12111216
@Test

0 commit comments

Comments
 (0)