fixes

Author: xaviviro

.github/workflows/test.yml

@@ -60,4 +60,3 @@ jobs:
 
       - name: Run mypy
         run: mypy src/toon_format
-        continue-on-error: true  # Mypy is informational only

PR_DESCRIPTION.md

@@ -121,7 +121,7 @@ tests/test_encoder.py ........................................      [100%]
 
 - [x] Ran `ruff check src/toon_format tests` - no issues
 - [x] Ran `ruff format src/toon_format tests` - code formatted
-- [x] Ran `mypy src/toon_format` - informational only (24 type hints to improve in future)
+- [x] Ran `mypy src/toon_format` - no issues
 - [x] All tests pass: `pytest tests/ -v`
 
 **Linter Output:**
@@ -283,13 +283,11 @@ mypy src/toon_format
 
 ### Code Quality Notes
 
-**Mypy Type Checking**: The project currently has 24 mypy type errors that are informational only. The CI is configured with `continue-on-error: true` for mypy checks, and the pyproject.toml has lenient mypy settings (`disallow_untyped_defs = false`, `check_untyped_defs = false`). These type hints can be improved incrementally in future releases without blocking the current functionality.
+**Type Safety**: The project has full type hint coverage with zero mypy errors. All type annotations are complete and validated, ensuring type safety throughout the codebase.
 
 All runtime behavior is validated through 73 comprehensive tests with 100% pass rate.
 
 ### Future Roadmap
-
-- Improve type hint coverage (address 24 mypy warnings)
 - Additional encoding options (custom formatters)
 - Performance optimizations for large datasets
 - Streaming encoder/decoder for very large files

src/toon_format/decoder.py

@@ -427,7 +427,7 @@ def decode_object(
     Returns:
         Decoded object
     """
-    result = {}
+    result: Dict[str, Any] = {}
     i = start_idx
     expected_depth = parent_depth if start_idx == 0 else parent_depth + 1
 
@@ -725,7 +725,7 @@ def decode_list_array(
     Raises:
         ToonDecodeError: If item count mismatch in strict mode
     """
-    result = []
+    result: List[Any] = []
     i = start_idx
     item_depth = header_depth + 1
 
@@ -772,7 +772,7 @@ def decode_list_array(
             else:
                 # - key[N]: array field in object
                 # This is an object with an array as its first field
-                item_obj = {}
+                item_obj: Dict[str, Any] = {}
                 array_val, next_i = decode_array_from_header(
                     lines, i, line.depth, item_header, strict
                 )
@@ -792,6 +792,7 @@ def decode_list_array(
                     field_header = parse_header(field_content)
                     if field_header is not None and field_header[0] is not None:
                         field_key, field_length, field_delim, field_fields = field_header
+                        assert field_key is not None  # Already checked above
                         field_val, next_i = decode_array_from_header(
                             lines, i, field_line.depth, field_header, strict
                         )
@@ -824,21 +825,21 @@ def decode_list_array(
         try:
             key_str, value_str = split_key_value(item_content)
             # It's an object item
-            item_obj = {}
+            obj_item: Dict[str, Any] = {}
 
             # First field
             key = parse_key(key_str)
             if not value_str:
                 # First field is nested object: fields at depth +2
                 nested = decode_object(lines, i + 1, line.depth + 1, strict)
-                item_obj[key] = nested
+                obj_item[key] = nested
                 # Skip nested content
                 i += 1
                 while i < len(lines) and lines[i].depth > line.depth + 1:
                     i += 1
             else:
                 # First field is primitive
-                item_obj[key] = parse_primitive(value_str)
+                obj_item[key] = parse_primitive(value_str)
                 i += 1
 
             # Remaining fields at depth +1
@@ -854,10 +855,11 @@ def decode_list_array(
                 field_header = parse_header(field_content)
                 if field_header is not None and field_header[0] is not None:
                     field_key, field_length, field_delim, field_fields = field_header
+                    assert field_key is not None  # Already checked above
                     field_val, next_i = decode_array_from_header(
                         lines, i, field_line.depth, field_header, strict
                     )
-                    item_obj[field_key] = field_val
+                    obj_item[field_key] = field_val
                     i = next_i
                     continue
 
@@ -867,17 +869,17 @@ def decode_list_array(
 
                     if not field_value_str:
                         # Nested object
-                        item_obj[field_key] = decode_object(lines, i + 1, field_line.depth, strict)
+                        obj_item[field_key] = decode_object(lines, i + 1, field_line.depth, strict)
                         i += 1
                         while i < len(lines) and lines[i].depth > field_line.depth:
                             i += 1
                     else:
-                        item_obj[field_key] = parse_primitive(field_value_str)
+                        obj_item[field_key] = parse_primitive(field_value_str)
                         i += 1
                 except ToonDecodeError:
                     break
 
-            result.append(item_obj)
+            result.append(obj_item)
         except ToonDecodeError:
             # Not an object, must be a primitive
             result.append(parse_primitive(item_content))

src/toon_format/encoders.py

@@ -1,6 +1,6 @@
 """Encoders for different value types."""
 
-from typing import List, Optional
+from typing import List, Optional, cast
 
 from .constants import LIST_ITEM_PREFIX
 from .normalize import (
@@ -12,7 +12,7 @@
     is_json_primitive,
 )
 from .primitives import encode_key, encode_primitive, format_header, join_encoded_values
-from .types import Depth, JsonArray, JsonObject, JsonValue, ResolvedEncodeOptions
+from .types import Depth, JsonArray, JsonObject, JsonPrimitive, JsonValue, ResolvedEncodeOptions
 from .writer import LineWriter
 
 
@@ -28,11 +28,11 @@ def encode_value(
         depth: Current indentation depth
     """
     if is_json_primitive(value):
-        writer.push(depth, encode_primitive(value, options.delimiter))
+        writer.push(depth, encode_primitive(cast(JsonPrimitive, value), options.delimiter))
     elif is_json_array(value):
-        encode_array(value, options, writer, depth, None)
+        encode_array(cast(JsonArray, value), options, writer, depth, None)
     elif is_json_object(value):
-        encode_object(value, options, writer, depth, None)
+        encode_object(cast(JsonObject, value), options, writer, depth, None)
 
 
 def encode_object(
@@ -71,11 +71,12 @@ def encode_key_value_pair(
         depth: Current indentation depth
     """
     if is_json_primitive(value):
-        writer.push(depth, f"{encode_key(key)}: {encode_primitive(value, options.delimiter)}")
+        primitive_str = encode_primitive(cast(JsonPrimitive, value), options.delimiter)
+        writer.push(depth, f"{encode_key(key)}: {primitive_str}")
     elif is_json_array(value):
-        encode_array(value, options, writer, depth, key)
+        encode_array(cast(JsonArray, value), options, writer, depth, key)
     elif is_json_object(value):
-        encode_object(value, options, writer, depth, key)
+        encode_object(cast(JsonObject, value), options, writer, depth, key)
 
 
 def encode_array(

src/toon_format/primitives.py

@@ -1,7 +1,7 @@
 """Primitive encoding utilities."""
 
 import re
-from typing import List, Optional
+from typing import List, Literal, Optional, Union
 
 from .constants import (
     BACKSLASH,
@@ -163,7 +163,7 @@ def format_header(
     length: int,
     fields: Optional[List[str]],
     delimiter: Delimiter,
-    length_marker: Optional[str],
+    length_marker: Union[str, Literal[False], None],
 ) -> str:
     """Format array/table header.
 

src/toon_format/types.py

@@ -24,7 +24,7 @@ class EncodeOptions(TypedDict, total=False):
 
     indent: int
     delimiter: Delimiter
-    lengthMarker: Literal["#", False]
+    lengthMarker: Union[Literal["#"], Literal[False]]
 
 
 class ResolvedEncodeOptions:
@@ -34,11 +34,11 @@ def __init__(
         self,
         indent: int = 2,
         delimiter: str = ",",
-        length_marker: Literal["#", False] = False,
+        length_marker: Union[Literal["#"], Literal[False]] = False,
     ) -> None:
         self.indent = indent
         self.delimiter = delimiter
-        self.lengthMarker = length_marker
+        self.lengthMarker: Union[str, Literal[False]] = length_marker
 
 
 class DecodeOptions: