6.2 support

[gabrielke]

Do you plan support for Liferay 6.2 soon?

[topolik]

Work is in progress... :)

[McAviti]

I tried to get it running and checked out the fsrepo-2.0 branch; the changes in the liferay classes seem not too hard to adapt to, but you seem to plan to heavy refactor the classes in the fsrepo package, because you commented out nearly the whole FSRepo class...? :)

[topolik]

Uh, Yes.

I'm refactoring almost whole codebase because I'm not very proud of the code. And to be able to support different versions (6.1 CE+EE, 6.2 CE+EE) I need to make it cleaner. I want to separate out permissions from the code itself and structure the code better to enable the support for the different portal versions.

It's possible to adapt 1.x code to 6.2, most of the new API is related to check in/out + locks which FSRepo doesn't support anyway. It's perhaps currently the easiest way to get 6.2 covered. Feel free to send me a pull request if you manage to do it.

Thanks!

[McAviti]

Sorry for the delay - I was ill for a week.
I have a working version here deployed on 6.2 GA2. I am not experienced with git/github - what do I have to do for a pull request?
I stashed back all the changes, rebased to master, merged the stashed changes back and created a branch out of it, made the local commit. What's next? I can't push the branch, obviously I lack access right for that. Do I have to do it with github's web interface?

[topolik]

I see.

For pull requests you need to fork the repository into your account.

Once it's forked you are able to clone it to your local computer.

Then you create a branch based on master, apply your changes and push the branch to origin (GH).

Once it's uploaded to GH, you go to GH, select the branch and click on "Pull Request" where you can add some notes. That's basically it.

Or, you could save the commit into file and send it by mail to me :)

[McAviti]

I always want to learn new things, but it's really not easy for a git beginner. ;)
Well, I made the pull request, I hope I did it correct now. If not please let me know and i send those five files. :)

[topolik]

Thanks @McAviti!!!!

I merged it into master and did some modifications, mostly source formatting.

I try to test it first and then make it public. But feel free to use it, I'll let you know if there are any changes.

Thanks again!