Merge pull request #136 from transifex/i18next-post-fixes

Fix plural handling in i18next backend

Author: Nikos Vasileiou

packages/i18next/README.md

@@ -92,6 +92,12 @@ npx txjs-cli push source.json --parser=i18next
 
 That's it. Given that the content is translated, translations will be downloaded over-the-air using the Transifex i18next backend.
 
+# Known limitations
+
+CLI does NOT parse and push the following key types:
+- keyWithArrayValue
+- keyWithObjectValue
+
 # License
 
 Licensed under Apache License 2.0, see [LICENSE](https://github.com/transifex/transifex-javascript/blob/HEAD/LICENSE) file.

packages/i18next/src/TransifexI18next.js

@@ -1,13 +1,18 @@
 import { createNativeInstance, explodePlurals } from '@transifex/native';
 
 export default class TransifexI18next {
-  constructor(services, options) {
+  constructor(options) {
     this.type = 'backend';
-    this.init(services, options);
+    this.options = options || {};
+    this.init();
   }
 
   init(services, backendOptions) {
-    this.tx = createNativeInstance(backendOptions);
+    this.options = {
+      ...(this.options || {}),
+      ...(backendOptions || {}),
+    };
+    this.tx = createNativeInstance(this.options);
   }
 
   read(language, namespace, callback) {
@@ -47,7 +52,7 @@ export default class TransifexI18next {
         return;
       }
       const baseKey = key.slice(0, -('_txplural'.length));
-      const plurals = explodePlurals(translations[key])[1];
+      const plurals = explodePlurals(translations[key].replace('{???,', '{count,'))[1];
       Object.keys(plurals).forEach((plural) => {
         data[`${baseKey}_${plural}`] = plurals[plural];
       });

packages/i18next/webpack.browser.js

@@ -27,6 +27,7 @@ module.exports = {
         use: {
           loader: 'babel-loader',
           options: {
+            sourceType: 'unambiguous',
             presets: ['@babel/preset-env'],
             plugins: [['@babel/transform-runtime']],
           },