Commit c2eadb3
fix(webapp): treat FAILED buffered runs as terminal in the run-header synth
`buildSyntheticRunHeader` only checked for `CANCELED` when mapping
`SyntheticRun.status` to the run-header's `status` / `isFinished`
fields. `SyntheticRun.status` can also be `"FAILED"` (set by
`readFallback.server.ts` when the buffer entry's status is FAILED —
e.g. after the drainer's terminal-failure path), so a FAILED buffered
run showed in the page header as `PENDING` + `isFinished: false`,
which left the Cancel button visible for an already-failed run.
Add a parallel `isFailed` branch (mapping to `SYSTEM_FAILURE`, matching
`buildSyntheticSpanRun`'s same-shape decision for the right-side panel)
and OR it into `isFinished`. Symmetric across the header + span panel
so admins no longer see "Pending" + "FAILED" simultaneously on the
same run.
Devin follow-up on PR #3757.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent b1e358f commit c2eadb3
1 file changed
Lines changed: 20 additions & 9 deletions
Lines changed: 20 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
15 | 21 | | |
16 | 22 | | |
17 | 23 | | |
| |||
23 | 29 | | |
24 | 30 | | |
25 | 31 | | |
| 32 | + | |
26 | 33 | | |
27 | 34 | | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
33 | | - | |
34 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
35 | 46 | | |
36 | 47 | | |
37 | 48 | | |
| |||
0 commit comments