Add same-net trace segment alignment cleanup#406
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddee3e61af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up b335495 addresses the review concern about moving traces into forbidden space: the alignment phase now rejects candidate moves that increase intersections with chip obstacles, other-net trace obstacles, or other-net label bounds. I also added a regression test for that guard and updated the two example snapshots where same-net alignment is the intended visual change. Local validation after the fix:
|
/claim #29
/claim #34
Summary
aligning_same_net_segmentsphase after untangling and before turn minimization.Tests
npx bun test tests\solvers\TraceCleanupSolver\align-nearby-same-net-trace-segments.test.tsnpx bun test tests\solvers\TraceCleanupSolvernpx biome check lib\solvers\TraceCleanupSolver\TraceCleanupSolver.ts lib\solvers\TraceCleanupSolver\alignNearbySameNetTraceSegments.ts tests\solvers\TraceCleanupSolver\align-nearby-same-net-trace-segments.test.tsnpm exec --package typescript@5.9.3 -- tsc --noEmit