Skip to content

Commit 4f224bf

Browse files
author
Yucheng Low
committed
Merge pull request #76 from esamanas/master
Minor tweaks from the other side
2 parents 607e5c5 + 6775abe commit 4f224bf

4 files changed

Lines changed: 17 additions & 5 deletions

File tree

oss_src/sframe/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,7 @@ make_copy_target(_local_sys_util_
5555
pylambda_worker_lib
5656
)
5757
add_dependencies(spark_unity _local_sys_util_)
58+
5859
file(DOWNLOAD http://s3-us-west-2.amazonaws.com/glbin-engine/spark_unity_0.4.jar ${CMAKE_CURRENT_BINARY_DIR}/spark_unity.jar
5960
EXPECTED_MD5 1ff73889a5484a90b0f1675641c16488)
61+

oss_src/unity/python/sframe/data_structures/sketch.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,6 @@ def quantile(self, quantile_val):
460460
out : float | str
461461
An estimate of the value at a quantile.
462462
"""
463-
_mt._get_metric_tracker().track('sketch.quantile.%g' % quantile_val)
464463

465464
with cython_context():
466465
return self.__proxy__.get_quantile(quantile_val)

oss_src/unity/python/sframe/toolkits/_main.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ def run(toolkit_name, options, verbose=True, show_progress=False):
5555
if (not verbose):
5656
glconnect.get_client().set_log_progress(False)
5757
# spawn progress threads
58-
server_addr = glconnect.get_server().get_server_addr()
59-
splits = server_addr.split(':')
6058
try:
6159
start_time = time.time()
6260
(success, message, params) = unity.run_toolkit(toolkit_name, options)
@@ -85,4 +83,7 @@ def run(toolkit_name, options, verbose=True, show_progress=False):
8583
if success:
8684
return params
8785
else:
86+
metric_name = 'toolkit.%s.toolkit_error' % (toolkit_name)
87+
_get_metric_tracker().track(metric_name, value=1, properties=track_props, send_sys_info=False)
88+
8889
raise ToolkitError(str(message))

oss_src/unity/python/sframe/util/__init__.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@
2727
import datetime as _datetime
2828
import time as _time
2929
import logging as _logging
30+
import sys as _sys
31+
32+
def _i_am_a_lambda_worker():
33+
if _re.match(".*lambda_worker.*", _sys.argv[0]) is not None:
34+
return True
35+
return False
3036

3137

3238
__LOGGER__ = _logging.getLogger(__name__)
@@ -70,8 +76,12 @@
7076
# Set module specific log levels
7177
logging.getLogger('librato').setLevel(logging.CRITICAL)
7278
logging.getLogger('requests').setLevel(logging.CRITICAL)
73-
logging.getLogger(root_package_name).setLevel(logging.INFO)
74-
logging.getLogger(__name__).setLevel(logging.INFO)
79+
if _i_am_a_lambda_worker():
80+
logging.getLogger(root_package_name).setLevel(logging.WARNING)
81+
logging.getLogger(__name__).setLevel(logging.WARNING)
82+
else:
83+
logging.getLogger(root_package_name).setLevel(logging.INFO)
84+
logging.getLogger(__name__).setLevel(logging.INFO)
7585

7686
#amend the logging configuration with a handler streaming to a message queue
7787

0 commit comments

Comments
 (0)