Skip to content

Commit 1750626

Browse files
hsbtclaude
andcommitted
Extract sub-bullet formatting into format_release_diff
The " * 1.2.3 to [v1.2.4][gem-v1.2.4], ..." sub-bullet was assembled in two places with the same expression. Pull it into a single helper so the formatting and the bundler-prefix stripping live in one spot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2885214 commit 1750626

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

tool/update-NEWS-github-release.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -263,15 +263,20 @@ def collect_gem_updates(versions_from, versions_to)
263263
results
264264
end
265265

266+
def format_release_diff(result)
267+
links = result[:release_range].map do |rel|
268+
tag = rel.sub(/^bundler-/, "")
269+
"[#{tag}][#{result[:name]}-#{tag}]"
270+
end
271+
" * #{result[:from_version]} to #{links.join(', ')}"
272+
end
273+
266274
def print_results(results)
267275
footnote_lines = []
268276

269277
results.each do |r|
270278
puts "* #{r[:name]} #{r[:version]}"
271-
links = r[:release_range].map { |rel|
272-
"[#{rel.sub(/^bundler-/, '')}][#{r[:name]}-#{rel.sub(/^bundler-/, '')}]"
273-
}
274-
puts " * #{r[:from_version]} to #{links.join(', ')}"
279+
puts format_release_diff(r)
275280
r[:footnote_links].each do |fl|
276281
footnote_lines << "[#{fl[:ref]}]: #{fl[:url]}"
277282
end
@@ -311,12 +316,7 @@ def update_news_md(results)
311316
i += 1
312317
end
313318

314-
# Insert the version diff sub-bullet
315-
links = r[:release_range].map { |rel|
316-
"[#{rel.sub(/^bundler-/, '')}][#{r[:name]}-#{rel.sub(/^bundler-/, '')}]"
317-
}
318-
sub_bullet = " * #{r[:from_version]} to #{links.join(', ')}\n"
319-
new_lines << sub_bullet
319+
new_lines << "#{format_release_diff(r)}\n"
320320
end
321321
else
322322
new_lines << line

0 commit comments

Comments
 (0)