[ruby/openssl] x509cert: check for error of X509_set_serialNumber()

ndossche · matzbot · commit 83b7a4d9a550 · 2026-04-20T09:55:38.000Z
This function may return 0 on error [1]. [1] https://manpages.debian.org/stretch/libssl-doc/X509_set_serialNumber.3ssl.en.html ruby/openssl@c6caa4f1c1
diff --git a/ext/openssl/ossl_x509cert.c b/ext/openssl/ossl_x509cert.c
@@ -311,7 +311,9 @@ ossl_x509_set_serial(VALUE self, VALUE num)
     X509 *x509;
 
     GetX509(self, x509);
-    X509_set_serialNumber(x509, num_to_asn1integer(num, X509_get_serialNumber(x509)));
+    if (!X509_set_serialNumber(x509, num_to_asn1integer(num, X509_get_serialNumber(x509)))) {
+        ossl_raise(eX509CertError, NULL);
+    }
 
     return num;
 }

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,9 @@ ossl_x509_set_serial(VALUE self, VALUE num)`
`311`	`311`	`X509 *x509;`
`312`	`312`
`313`	`313`	`GetX509(self, x509);`
`314`		`- X509_set_serialNumber(x509, num_to_asn1integer(num, X509_get_serialNumber(x509)));`
	`314`	`+ if (!X509_set_serialNumber(x509, num_to_asn1integer(num, X509_get_serialNumber(x509)))) {`
	`315`	`+ ossl_raise(eX509CertError, NULL);`
	`316`	`+ }`
`315`	`317`
`316`	`318`	`return num;`
`317`	`319`	`}`