Skip to content

Commit a6c6e56

Browse files
authored
Fix random timeout in test_thread_join_during_finalizers on Windows (ruby#16650)
Reduce the number of spawned processes from 50 to 20 and increase the timeout from 30s to 60s. Process creation is expensive on Windows, and the combination caused the test to exceed the 30s limit on Windows CI.
1 parent 1d98daa commit a6c6e56

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

test/ruby/test_thread.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1667,7 +1667,7 @@ def test_mn_threads_sub_millisecond_sleep
16671667

16681668
# [Bug #21926]
16691669
def test_thread_join_during_finalizers
1670-
assert_separately([], "#{<<~"begin;"}\n#{<<~'end;'}", timeout: 30)
1670+
assert_separately([], "#{<<~"begin;"}\n#{<<~'end;'}", timeout: 60)
16711671
begin;
16721672
require 'open3'
16731673
@@ -1690,7 +1690,7 @@ def self.make_finalizer(stdin, stdout, stderr, wait_thread)
16901690
end
16911691
end
16921692
1693-
50.times { ProcessWrapper.new }
1693+
20.times { ProcessWrapper.new }
16941694
GC.stress = true
16951695
1000.times { Object.new }
16961696
end;

0 commit comments

Comments
 (0)