Skip to content

Commit fbe968e

Browse files
hsbtclaude
andcommitted
Drop dead code from NEWS.md updater
* Remove the bundler branch in resolve_repo: collect_gem_updates skips bundler before resolve_repo is ever consulted, so the mapping was unreachable. * Inline the gem_name_normalized ternary, which had the same value in both arms. * Remove the unused tag field from footnote_links and switch to map. * Drop require "set" since Set is autoloaded on supported Ruby versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 466f675 commit fbe968e

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

tool/update-NEWS-github-release.rb

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
require "bundler/inline"
44
require "json"
55
require "net/http"
6-
require "set"
76
require "uri"
87

98
gemfile do
@@ -162,8 +161,6 @@ def resolve_repo(name)
162161
{ repo: name, org: "minitest" }
163162
when "test-unit"
164163
{ repo: name, org: "test-unit" }
165-
when "bundler"
166-
{ repo: "rubygems", org: "ruby" }
167164
else
168165
{ repo: name, org: "ruby" }
169166
end
@@ -209,12 +206,10 @@ def collect_gem_updates(versions_from, versions_to)
209206
release_range = fetch_release_range(name, versions_from[name], version, org, repo)
210207
next unless release_range
211208

212-
footnote_links = []
213-
release_range.each do |rel|
214-
footnote_links << {
209+
footnote_links = release_range.map do |rel|
210+
{
215211
ref: "#{name}-#{rel.sub(/^bundler-/, '')}",
216212
url: "https://github.com/#{org}/#{repo}/releases/tag/#{rel}",
217-
tag: rel.sub(/^bundler-/, ''),
218213
}
219214
end
220215

@@ -267,12 +262,11 @@ def update_news_md(results)
267262
# Check if this line is a gem bullet like "* gemname x.y.z"
268263
if line =~ /^\* ([A-Za-z0-9_\-]+)\s+(\d+(?:\.\d+){0,3})\b/
269264
gem_name = $1
270-
gem_name_normalized = gem_name == "RubyGems" ? "RubyGems" : gem_name
271265

272266
new_lines << line
273267

274-
if result_by_name.key?(gem_name_normalized)
275-
r = result_by_name[gem_name_normalized]
268+
if result_by_name.key?(gem_name)
269+
r = result_by_name[gem_name]
276270

277271
# Skip any existing sub-bullet lines that follow (lines starting with spaces + *)
278272
while i + 1 < lines.length && lines[i + 1] =~ /^\s+\*/

0 commit comments

Comments
 (0)