Skip to content

Commit 316ec84

Browse files
committed
Fix: Variable '$f' is introduced in a outer loop and overridden here
1 parent 4c6a25f commit 316ec84

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

class/files/classes/ClassFiles.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,9 +412,9 @@ private function getValuesInObject($moduleDirname, $table, $fields)
412412
$fieldNameDesc = substr($fieldElementName, strrpos($fieldElementName, ':'), strlen($fieldElementName));
413413
$topicTableName = str_replace(': ', '', strtolower($fieldNameDesc));
414414
$fieldsTopics = $this->getTableFields($fieldElementMid, $fieldElementTid);
415-
foreach (array_keys($fieldsTopics) as $f) {
416-
$fieldNameTopic = $fieldsTopics[$f]->getVar('field_name');
417-
if (1 == $fieldsTopics[$f]->getVar('field_main')) {
415+
foreach (array_keys($fieldsTopics) as $g) {
416+
$fieldNameTopic = $fieldsTopics[$g]->getVar('field_name');
417+
if (1 == $fieldsTopics[$g]->getVar('field_main')) {
418418
$fieldMainTopic = $fieldNameTopic;
419419
}
420420
}

class/files/classes/ClassFormElements.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -747,15 +747,15 @@ public function renderElements()
747747
$fieldNameDesc = substr($fieldElementName, strrpos($fieldElementName, ':'), strlen($fieldElementName));
748748
$topicTableName = str_replace(': ', '', $fieldNameDesc);
749749
$fieldsTopics = $ttf->getTableFields($fieldElementMid, $fieldElementTid);
750-
foreach (array_keys($fieldsTopics) as $f) {
751-
$fieldNameTopic = $fieldsTopics[$f]->getVar('field_name');
752-
if ((0 == $f) && (1 == $table->getVar('table_autoincrement'))) {
750+
foreach (array_keys($fieldsTopics) as $g) {
751+
$fieldNameTopic = $fieldsTopics[$g]->getVar('field_name');
752+
if ((0 == $g) && (1 == $table->getVar('table_autoincrement'))) {
753753
$fieldIdTopic = $fieldNameTopic;
754754
}
755-
if (1 == $fieldsTopics[$f]->getVar('field_parent')) {
755+
if (1 == $fieldsTopics[$g]->getVar('field_parent')) {
756756
$fieldPidTopic = $fieldNameTopic;
757757
}
758-
if (1 == $fieldsTopics[$f]->getVar('field_main')) {
758+
if (1 == $fieldsTopics[$g]->getVar('field_main')) {
759759
$fieldMainTopic = $fieldNameTopic;
760760
}
761761
}

0 commit comments

Comments
 (0)