File tree Expand file tree Collapse file tree
main/kotlin/io/github/typesafegithub/workflows/shared/internal/model
test/kotlin/io/github/typesafegithub/workflows/shared/internal/model Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -25,7 +25,7 @@ data class Version(
2525
2626 override fun toString (): String = version
2727
28- fun isMajorVersion (): Boolean = version.contains( " . " ). not ()
28+ fun isMajorVersion (): Boolean = version.removePrefix( " v " ).removePrefix( " V " ).toIntOrNull() != null
2929
3030 suspend fun getReleaseDate () = dateProvider()
3131}
Original file line number Diff line number Diff line change @@ -11,9 +11,8 @@ class VersionTest :
1111 Pair (" v1.2" , false ),
1212 Pair (" v3" , true ),
1313 Pair (" V3" , true ),
14- // Incorrect behavior, will be fixed in https://github.com/typesafegithub/github-workflows-kt/issues/1670
15- Pair (" v3-prerelease" , true ),
16- Pair (" beta-v3" , true ),
14+ Pair (" v3-prerelease" , false ),
15+ Pair (" beta-v3" , false ),
1716 ).forEach { (version, isMajor) ->
1817 test(" isMajorVersion works correctly for $version " ) {
1918 Version (version).isMajorVersion() shouldBe isMajor
You can’t perform that action at this time.
0 commit comments