chore(server)!: remove old '/binding' route (#1633)

Closes #1492.

Author: krzema12

.github/workflows/bindings-server.main.kts

@@ -81,16 +81,6 @@ workflow(
 
         cleanMavenLocal()
 
-        run(
-            name = "Execute the script using the bindings from the server - with /binding",
-            command = """
-                mv .github/workflows/test-script-consuming-jit-bindings-old.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings-old.main.kts
-                .github/workflows/test-script-consuming-jit-bindings-old.main.kts
-            """.trimIndent(),
-        )
-
-        cleanMavenLocal()
-
         run(
             name = "Execute the script using the bindings from the server",
             command = """
@@ -109,15 +99,6 @@ workflow(
             """.trimIndent(),
         )
 
-        run(
-            name = "Fetch maven-metadata.xml for top-level action - with /binding",
-            command = "curl --fail http://localhost:8080/binding/actions/checkout/maven-metadata.xml | grep '<version>v4</version>'",
-        )
-        run(
-            name = "Fetch maven-metadata.xml for nested action - with /binding",
-            command = "curl --fail http://localhost:8080/binding/actions/cache__save/maven-metadata.xml | grep '<version>v4</version>'",
-        )
-
         run(
             name = "Fetch maven-metadata.xml for top-level action",
             command = "curl --fail http://localhost:8080/actions/checkout/maven-metadata.xml | grep '<version>v4</version>'",

.github/workflows/bindings-server.yaml

@@ -49,36 +49,22 @@ jobs:
       name: 'Clean Maven Local to fetch required POMs again'
       run: 'rm -rf ~/.m2/repository/'
     - id: 'step-5'
-      name: 'Execute the script using the bindings from the server - with /binding'
-      run: |-
-        mv .github/workflows/test-script-consuming-jit-bindings-old.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings-old.main.kts
-        .github/workflows/test-script-consuming-jit-bindings-old.main.kts
-    - id: 'step-6'
-      name: 'Clean Maven Local to fetch required POMs again'
-      run: 'rm -rf ~/.m2/repository/'
-    - id: 'step-7'
       name: 'Execute the script using the bindings from the server'
       run: |-
         mv .github/workflows/test-script-consuming-jit-bindings.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings.main.kts
         .github/workflows/test-script-consuming-jit-bindings.main.kts
-    - id: 'step-8'
+    - id: 'step-6'
       name: 'Clean Maven Local to fetch required POMs again'
       run: 'rm -rf ~/.m2/repository/'
-    - id: 'step-9'
+    - id: 'step-7'
       name: 'Execute the script using bindings but without dependency on library'
       run: |-
         mv .github/workflows/test-served-bindings-depend-on-library.main.do-not-compile.kts .github/workflows/test-served-bindings-depend-on-library.main.kts
         .github/workflows/test-served-bindings-depend-on-library.main.kts
-    - id: 'step-10'
-      name: 'Fetch maven-metadata.xml for top-level action - with /binding'
-      run: 'curl --fail http://localhost:8080/binding/actions/checkout/maven-metadata.xml | grep ''<version>v4</version>'''
-    - id: 'step-11'
-      name: 'Fetch maven-metadata.xml for nested action - with /binding'
-      run: 'curl --fail http://localhost:8080/binding/actions/cache__save/maven-metadata.xml | grep ''<version>v4</version>'''
-    - id: 'step-12'
+    - id: 'step-8'
       name: 'Fetch maven-metadata.xml for top-level action'
       run: 'curl --fail http://localhost:8080/actions/checkout/maven-metadata.xml | grep ''<version>v4</version>'''
-    - id: 'step-13'
+    - id: 'step-9'
       name: 'Fetch maven-metadata.xml for nested action'
       run: 'curl --fail http://localhost:8080/actions/cache__save/maven-metadata.xml | grep ''<version>v4</version>'''
   deploy:

.github/workflows/test-script-consuming-jit-bindings-old.main.do-not-compile.kts

@@ -39,18 +39,6 @@ fun main() {
             setOpenTelemetry(openTelemetry)
         }
         routing {
-            // TODO: remove this route once known clients are migrated
-            // See https://github.com/typesafegithub/github-workflows-kt/issues/1492
-            route("/binding") {
-                route("{owner}/{name}/{version}/{file}") {
-                    artifact(bindingsCache)
-                }
-
-                route("{owner}/{name}/{file}") {
-                    metadata()
-                }
-            }
-
             route("{owner}/{name}/{version}/{file}") {
                 artifact(bindingsCache)
             }