Skip to content

Commit 9639fd4

Browse files
authored
fix(server): return 'not found' for maven-metadata.xml if no major version found (#1775)
Part of #1774. It doesn't fix the entire issue because we should be able to see the major versions, even if they don't have the `v` in front, because such versions are consumable as action bindings. This change just prevents the failures of the server.
1 parent 04ecd60 commit 9639fd4

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

maven-binding-builder/src/main/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuilding.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import io.github.typesafegithub.workflows.actionbindinggenerator.domain.ActionCo
44
import io.github.typesafegithub.workflows.shared.internal.fetchAvailableVersions
55
import java.time.format.DateTimeFormatter
66

7-
internal suspend fun ActionCoords.buildMavenMetadataFile(githubToken: String): String {
7+
internal suspend fun ActionCoords.buildMavenMetadataFile(githubToken: String): String? {
88
val availableMajorVersions =
99
fetchAvailableVersions(owner = owner, name = name, githubToken = githubToken)
1010
.filter { it.isMajorVersion() }
11-
val newest = availableMajorVersions.max()
11+
val newest = availableMajorVersions.maxOrNull() ?: return null
1212
val lastUpdated =
1313
DateTimeFormatter
1414
.ofPattern("yyyyMMddHHmmss")

maven-binding-builder/src/main/kotlin/io/github/typesafegithub/workflows/mavenbinding/PackageArtifactsBuilding.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package io.github.typesafegithub.workflows.mavenbinding
33
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.ActionCoords
44

55
suspend fun ActionCoords.buildPackageArtifacts(githubToken: String): Map<String, String> {
6-
val mavenMetadata = buildMavenMetadataFile(githubToken = githubToken)
6+
val mavenMetadata = buildMavenMetadataFile(githubToken = githubToken) ?: return emptyMap()
77
return mapOf(
88
"maven-metadata.xml" to mavenMetadata,
99
"maven-metadata.xml.md5" to mavenMetadata.md5Checksum(),

0 commit comments

Comments
 (0)