fix(server): respond 'not found' if no commit hash given but required (#2191)

Fixes #2190.

Author: krzema12

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/ArtifactRoutes.kt

@@ -125,7 +125,7 @@ private suspend fun ApplicationCall.toBindingArtifacts(
     refresh: Boolean,
     bindingsCache: LoadingCache<BindingsServerRequest, CachedVersionArtifact>,
 ): VersionArtifacts? {
-    val parsedRequest = parameters.parseRequest(extractVersion = true)
+    val parsedRequest = parameters.parseRequest(extractVersion = true) ?: return null
 
     logger.info { "➡️ Requesting ${parsedRequest.actionCoords.prettyPrint}" }
     if (refresh) {

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/MetadataRoutes.kt

@@ -42,7 +42,7 @@ private fun Route.headMetadata(
     refresh: Boolean = false,
 ) {
     head {
-        val request = call.parameters.parseRequest(extractVersion = false)
+        val request = call.parameters.parseRequest(extractVersion = false) ?: return@head call.respondNotFound()
 
         if (refresh) {
             metadataCache.invalidate(request)
@@ -66,7 +66,7 @@ private fun Route.getMetadata(
     refresh: Boolean = false,
 ) {
     get {
-        val request = call.parameters.parseRequest(extractVersion = false)
+        val request = call.parameters.parseRequest(extractVersion = false) ?: return@get call.respondNotFound()
 
         logger.info { "➡️ Requesting metadata for ${request.actionCoords.prettyPrintWithoutVersion}" }
 

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/RequestParsing.kt

@@ -6,7 +6,10 @@ import io.github.typesafegithub.workflows.actionbindinggenerator.domain.Signific
 import io.github.typesafegithub.workflows.mavenbinding.BindingsServerRequest
 import io.ktor.http.Parameters
 
-fun Parameters.parseRequest(extractVersion: Boolean): BindingsServerRequest {
+/**
+ * Returns `null` if the request doesn't make sense and the service should return no resource.
+ */
+fun Parameters.parseRequest(extractVersion: Boolean): BindingsServerRequest? {
     val owner = this["owner"]!!
     val nameAndPathAndSignificantVersionParts = this["name"]!!.split("___", limit = 2)
     val nameAndPath = nameAndPathAndSignificantVersionParts.first()
@@ -36,7 +39,11 @@ fun Parameters.parseRequest(extractVersion: Boolean): BindingsServerRequest {
         if (extractVersion) {
             val versionPart = this["version"]!!
             if (pinToCommit) {
-                versionPart.split("__")[1]
+                val versionParts = versionPart.split("__")
+                if (versionParts.size < 2) {
+                    return null
+                }
+                versionParts[1]
             } else {
                 versionPart
             }

jit-binding-server/src/test/kotlin/io/github/typesafegithub/workflows/jitbindingserver/RequestParsingTest.kt

@@ -6,6 +6,7 @@ import io.github.typesafegithub.workflows.actionbindinggenerator.domain.Signific
 import io.github.typesafegithub.workflows.actionbindinggenerator.domain.SignificantVersion.MINOR
 import io.github.typesafegithub.workflows.mavenbinding.BindingsServerRequest
 import io.kotest.core.spec.style.FunSpec
+import io.kotest.matchers.nulls.shouldBeNull
 import io.kotest.matchers.shouldBe
 import io.ktor.http.Parameters
 import io.ktor.http.ParametersBuilder
@@ -104,6 +105,42 @@ class RequestParsingTest :
                                 ),
                         )
                 }
+
+                test("parses commit_lenient syntax") {
+                    val parameters =
+                        createParameters(
+                            owner = "o",
+                            name = "act___commit_lenient",
+                            version = "v1.2.3__323898970401d85df44b3324a610af9a862d54b3",
+                        )
+
+                    parameters.parseRequest(extractVersion = true) shouldBe
+                        BindingsServerRequest(
+                            rawName = "act___commit_lenient",
+                            rawVersion = "v1.2.3__323898970401d85df44b3324a610af9a862d54b3",
+                            actionCoords =
+                                ActionCoords(
+                                    owner = "o",
+                                    name = "act",
+                                    version = "323898970401d85df44b3324a610af9a862d54b3",
+                                    significantVersion = FULL,
+                                    comment = "v1.2.3",
+                                    versionForTypings = "v1.2.3",
+                                    path = null,
+                                ),
+                        )
+                }
+
+                test("parses commit_lenient syntax and no commit hash given") {
+                    val parameters =
+                        createParameters(
+                            owner = "o",
+                            name = "act___commit_lenient",
+                            version = "v1.2.3",
+                        )
+
+                    parameters.parseRequest(extractVersion = true).shouldBeNull()
+                }
             }
         },
     )