Add @Value to the list of default initializers

[WoutDeleu]

I see that https://github.com/uber/NullAway/blob/master/nullaway/src/main/java/com/uber/nullaway/ErrorProneCLIFlagsConfig.java#L177 has support for things like @Autowired and @MockitoBean. Can we add @value also to this list for Value injections in Test or in the constructor?

As a workaround, I currently suppress the error like this:

  @SuppressWarnings("NullAway.Init")
  @Value
  String a;

or, as an alternative, to do it globally using a maven argument: -XepOpt:NullAway:ExcludedFieldAnnotations=org.springframework.beans.factory.annotation.Value

[msridhar]

Thanks for the report! I'm open to doing this but I had one concern. It seems a field with a @Value annotation may still get initialized to null in certain cases. E.g., one could write:

@Value("#{null}")
private String x;   // x will be null

So I was wondering if there's an easy way to do a bit more checking, like looking inside the @Value annotation argument for null and skipping those cases. I'll think a bit more about this, but this support is on our todo list.