Skip to content

Commit 3c31c1e

Browse files
committed
For #13673, UE 5.4 support
1 parent 5141085 commit 3c31c1e

2 files changed

Lines changed: 15 additions & 15 deletions

File tree

core/hooks/bootstrap.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
# This file is provided by Epic Games, Inc. and is subject to the license
2-
# file included in this repository.
1+
# Copyright 2020 GPL Solutions, LLC. All rights reserved.
2+
#
3+
# Use of this software is subject to the terms of the GPL Solutions license
4+
# agreement provided at the time of installation or download, or which otherwise
5+
# accompanies this software in either electronic or hard copy form.
6+
#
37

48
"""
59
This hook is used override some of the functionality of the :class:`~sgtk.bootstrap.ToolkitManager`.
@@ -27,11 +31,11 @@
2731

2832
class Bootstrap(get_hook_baseclass()):
2933
"""
30-
Override the bootstrap core hook to cache some bundles ourselves.
34+
Override the bootstrap core hook to cache ourself some bundles.
3135
http://developer.shotgunsoftware.com/tk-core/core.html#bootstrap.Bootstrap
3236
"""
33-
# List of github repos for which we download releases, with a github token to
34-
# do the download if the repo is private
37+
# List of github repos for which we download releases, with a token to do
38+
# the download
3539
_download_release_from_github = [
3640
("ue4plugins/tk-framework-unrealqt", ""),
3741
("GPLgithub/tk-framework-unrealqt", ""),
@@ -97,7 +101,7 @@ def populate_bundle_cache_entry(self, destination, descriptor, **kwargs):
97101
if self.shotgun.config.proxy_handler:
98102
# Re-use proxy settings from the Shotgun connection
99103
opener = url2.build_opener(
100-
self.parent.shotgun.config.proxy_handler,
104+
self.shotgun.config.proxy_handler,
101105
)
102106
url2.install_opener(opener)
103107

@@ -152,13 +156,9 @@ def populate_bundle_cache_entry(self, destination, descriptor, **kwargs):
152156

153157
if not extracted:
154158
raise RuntimeError(
155-
"Couldn't retrieve a suitable asset for %s %s from %s" % (
156-
version,
157-
pname,
158-
[
159-
a["name"] for a in response_d["assets"]
160-
]
161-
)
159+
"Couldn't retrieve a suitable asset from %s" % [
160+
a["name"] for a in response_d["assets"]
161+
]
162162
)
163163
self.logger.info(
164164
"Extracted files: %s from %s" % (
@@ -233,7 +233,7 @@ def _download_zip_github_asset(self, asset, destination, token):
233233
if self.shotgun.config.proxy_handler:
234234
# Re-use proxy settings from the Shotgun connection
235235
opener = url2.build_opener(
236-
self.parent.shotgun.config.proxy_handler,
236+
self.shotgun.config.proxy_handler,
237237
auth_handler
238238
)
239239
else:

env/includes/unreal/frameworks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
frameworks:
77
tk-framework-unrealqt_v1.x.x:
88
location:
9-
version: v1.3.0-rc.2
9+
version: v1.3.0-rc.3
1010
type: github_release
1111
organization: GPLgithub
1212
# organization: ue4plugins

0 commit comments

Comments
 (0)