From 04763f7ce65d9f126dfb22d9fb0ee969c63034a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Mon, 25 May 2026 10:25:48 +0000 Subject: [PATCH] Don't return EOT_SUCCESS when writeFontBuffer fails The second result check in EOT2ttf_buffer tested the metadata result instead of the write result. --- src/libeot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libeot.c b/src/libeot.c index e234556..0f15e51 100644 --- a/src/libeot.c +++ b/src/libeot.c @@ -79,8 +79,8 @@ enum EOTError EOT2ttf_buffer(const uint8_t *font, unsigned fontSize, font + metadataOut->fontDataOffset, metadataOut->fontDataSize, metadataOut->flags & TTEMBED_TTCOMPRESSED, metadataOut->flags & TTEMBED_XORENCRYPTDATA, fontOut, fontSizeOut); - if (result >= EOT_WARN) { - EOTprintError(result, stderr); + if (writeResult >= EOT_WARN) { + EOTprintError(writeResult, stderr); } else if (writeResult != EOT_SUCCESS) { return writeResult; }