Disk/Disks do not show SSD temperature. Array->Disks does

[rkozyak]

Environment

Unraid OS Version:

7.2.2

Are you using a reverse proxy?

No - Issue tested with direct access to server.

Pre-submission Checklist

• I have verified that my Unraid OS is up to date
• I have tested this issue by accessing my server directly (not through a reverse proxy)
• This is not an Unraid Connect related issue (if it is, please submit via the support form instead)

Issue Description

API query for disk or disks temperature returns null for SSD in cache. Query for array -> cache -> temp returns the correct temperature for those disks. Hard drives in array show temperature correctly.

Example with no Temp:

query ExampleQuery($diskId: PrefixedID!) {
  disk(id: $diskId) {
    name
    temperature
  }
}

Returns:

{
  "data": {
    "disk": {
      "name": "Samsung SSD 990 EVO Plus 1TB",
      "temperature": null
    }
  }
}

Example showing Temp:

query ExampleQuery {
  array {
    caches {
      temp
      name
    }
  }
}

Returns:

{
  "data": {
    "array": {
      "caches": [
        {
          "temp": 33,
          "name": "cache"
        },
        {
          "temp": 33,
          "name": "cache2"
        }
      ]
    }
  }
}

Steps to Reproduce

1. Query SSD though GraphQL Sandbox or API calling disk or disks (no temp shown)
2. Querry SSD though array (temp shown)

Expected Behavior

Disk/Disks should return temperature of SSD similar to array->disks or array->cache

Actual Behavior

No temperature is shown for SSD from Disk/Disks

Additional Context

[elibosley]

Thank you! This is related to the data being displayed on both endpoints - the Array -> Disks is from Unraid's state files, while the disks view is from our system information library. Appreciate the callout and we'll work towards unifying the fields.

[MitchellThompkins]

@elibosley should all metrics of the same type be sourced from a single module? For example, all temperature data from the temperature module rather than being pulled from disparate sources. I'm thinking this could be driven by the changes in #1597?

[elibosley]

@elibosley should all metrics of the same type be sourced from a single module? For example, all temperature data from the temperature module rather, than being pulled from disparate sources. I'm thinking this could be driven by the changes in #1597?

That's probably a good idea. Would simplify the loading path I think.