Merge pull request #2537 from SimonFair/fix(VM_Manager)-snap-GPF-fix

fix(VM_Manager): fix gpf issues with snapshots and php 8.4

Author: limetech

emhttp/plugins/dynamix.vm.manager/include/libvirt_helpers.php

@@ -1886,7 +1886,11 @@ function write_snapshots_database($vm,$name,$state,$desc,$method="QEMU") {
 		$noxml = "";
 		$snaps_json = file_get_contents($dbpath."/snapshots.db");
 		$snaps = json_decode($snaps_json,true);
-		$snapshot_res=$lv->domain_snapshot_lookup_by_name($vm,$name);
+		$snapshot_xml = @file_get_contents("/etc/libvirt/qemu/snapshot/{$vm}/{$name}.xml");
+		if (empty($snapshot_xml)) {
+			$snapshot_xml = trim(shell_exec("virsh snapshot-dumpxml ".escapeshellarg($vm)." ".escapeshellarg($name)." 2>/dev/null"));
+		}
+		$snapshot_res = !empty($snapshot_xml);
 		if (!$snapshot_res) {
 			 # Manual Snap no XML
 		if ($state == "shutoff" && ($method == "ZFS" || $method == "BTRFS")) {
@@ -1903,7 +1907,7 @@ function write_snapshots_database($vm,$name,$state,$desc,$method="QEMU") {
 			$noxml = "noxml";
 		}
 		} else {
-		$snapshot_xml=$lv->domain_snapshot_get_xml($snapshot_res);
+
 		$a = simplexml_load_string($snapshot_xml);
 		$a = json_encode($a);
 		$b = json_decode($a, TRUE);
@@ -2133,7 +2137,9 @@ function vm_snapshot($vm,$snapshotname, $snapshotdescinput, $free = "yes", $meth
 			if ($logging) qemu_log($vm,"Success write snap db");
 			$ret = write_snapshots_database("$vm","$name",$state,$snapshotdescinput,$method);
 			#remove meta data
-			if ($ret != "noxml") $ret = $lv->domain_snapshot_delete($vm, "$name" ,2);
+			if ($ret != "noxml") {
+				exec("virsh snapshot-delete ".escapeshellarg($vm)." ".escapeshellarg($name)." --metadata 2>&1", $snapDelOut, $snapDelRtn);
+			}
 		}
 		return $arrResponse;