Skip to content

Commit cec4424

Browse files
committed
reverting back to previous save with clear message to the user
Signed-off-by: vsoch <vsochat@stanford.edu>
1 parent e0ebe98 commit cec4424

1 file changed

Lines changed: 14 additions & 27 deletions

File tree

urlchecker/client/check.py

Lines changed: 14 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -88,31 +88,18 @@ def main(args, extra):
8888
logger.info("Cleaning up %s..." % path)
8989
delete_repo(path)
9090

91-
# force pass
92-
if args.force_pass:
93-
if check_results['failed']:
94-
print("\n\nDone. The following urls did not pass:")
95-
for failed_url in check_results['failed']:
96-
print_failure(failed_url)
97-
sys.exit(1)
98-
99-
else:
100-
print("\n\nDone. All URLS passed.")
101-
sys.exit(1)
102-
103-
# no force pass
91+
# Case 1: We didn't find any urls to check
92+
if not check_results['failed'] and not check_results['passed']:
93+
print("\n\nDone. No urls were collected.")
94+
sys.exit(0)
95+
96+
# Case 2: We had errors, but force pass is True
97+
elif args.force_pass and check_results['failed']:
98+
print("\n\nDone. The following urls did not pass:")
99+
for failed_url in check_results['failed']:
100+
print_failure(failed_url)
101+
sys.exit(1)
102+
104103
else:
105-
# Case 1: We didn't find any urls to check
106-
if not check_results['failed'] and not check_results['passed']:
107-
print("\n\nDone. No urls were collected.")
108-
sys.exit(0)
109-
110-
# Case 2 : Only working urls found
111-
elif not check_results['failed'] and check_results['passed']:
112-
print("\n\nDone. All URLS passed.")
113-
sys.exit(0)
114-
115-
# exit
116-
else:
117-
print("\n\nDone.")
118-
sys.exit(0)
104+
print("\n\nDone. All URLS passed.")
105+
sys.exit(0)

0 commit comments

Comments
 (0)