Skip to content

fix(delete): handle already-exited processes during force-delete #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yashika0724 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

fix(delete): handle already-exited processes during force-delete #752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d07366
fix(delete): handle already-exited processes during force-delete
Yashika0724 Jun 7, 2026
1b26bc7
Merge remote-tracking branch 'origin/main' into fix/force-delete-alre…
Yashika0724 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cmd/urunc/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,14 @@ status of "ubuntu01" as "stopped" the following will delete resources held for
return err
}
if cmd.Bool("force") {
err := unikontainer.Kill()
if err != nil {
return err
// Forcing a delete must remain idempotent even if the
// container's process has already exited (e.g. it was
// killed by a previous attempt or exited on its own).
// Log any kill error but still proceed to clean up the
// container's resources, otherwise a stale state would
// make every subsequent delete attempt fail the same way.
if err := unikontainer.Kill(); err != nil {
logrus.WithError(err).Error("failed to kill container during forced delete")
}
}
err = unikontainer.Delete()
Expand Down