Merge External PR: Merge main-pr597 into main#757
Merged
Conversation
Adds a table-driven test that covers the main branches of BuildExecCmd: static flags, memory default and custom value, vCPUs, seccomp, the architecture machine flag, networking (no-net, generic tap, custom MonitorNetCli, vhost), initrd, sharedfs (9pfs / virtiofs), block devices (generic and ExactArgs), MonitorCli extras, vsock, and the kernel command append rule. A small fakeUnikernel stub keeps the tests focused on BuildExecCmd itself. PR: #597 Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
✅ Deploy Preview for urunc canceled.
|
1 similar comment
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by GitHub Actions to merge changes from main-pr597 into main.