Add UserRoleSprunje tests

Author: lcharette

.vscode/tasks.json

@@ -11,7 +11,7 @@
                     "XDEBUG_CONFIG": "idekey=VSCODE",
                 }
             },
-            "command": "printf '\\33c\\e[3J' && vendor/bin/phpunit",
+            "command": "printf '\\33c\\e[3J' && vendor/bin/phpunit --stop-on-failure --stop-on-error",
             "problemMatcher": [],
             "group": {
                 "kind": "build",

app/src/App.php

@@ -11,6 +11,7 @@
 namespace App\ExtendUser;
 
 use App\ExtendUser\Database\Migrations\v400\MembersTable;
+use App\ExtendUser\ServicesProvider\MemberModelService;
 use UserFrosting\Sprinkle\Account\Account;
 use UserFrosting\Sprinkle\Admin\Admin;
 use UserFrosting\Sprinkle\Core\Core;
@@ -93,7 +94,7 @@ public function getRoutes(): array
     public function getServices(): array
     {
         return [
-            Services::class,
+            MemberModelService::class,
         ];
     }
 

app/src/Database/Models/MemberAux.php

@@ -19,13 +19,20 @@
  */
 class MemberAux extends Model
 {
+    /**
+     * The table doesn't have timestamps columns
+     */
     public $timestamps = false;
 
     /**
-     * @var string The name of the table for the current model.
+     * @var string The name of the table for the current model. We defined it,
+     *             because the table name is different than the model name
      */
     protected $table = 'members';
 
+    /**
+     * Define the fillable columns
+     */
     protected $fillable = [
         'city',
         'country',

app/src/Services.php …/ServicesProvider/MemberModelService.phpapp/src/Services.php renamed to app/src/ServicesProvider/MemberModelService.php app/src/Services.php renamed to app/src/ServicesProvider/MemberModelService.php

@@ -8,15 +8,15 @@
  * @license   https://github.com/userfrosting/extend-user/blob/5.0/LICENSE.md (MIT License)
  */
 
-namespace App\ExtendUser;
+namespace App\ExtendUser\ServicesProvider;
 
 use App\ExtendUser\Controller\MemberPageAction;
 use App\ExtendUser\Database\Models\Member;
 use UserFrosting\ServicesProvider\ServicesProviderInterface;
 use UserFrosting\Sprinkle\Account\Database\Models\Interfaces\UserInterface;
 use UserFrosting\Sprinkle\Admin\Controller\User\UserPageAction;
 
-class Services implements ServicesProviderInterface
+class MemberModelService implements ServicesProviderInterface
 {
     public function register(): array
     {

app/tests/Controller/MemberPageActionTest.php

@@ -35,6 +35,9 @@ public function setUp(): void
         $this->refreshDatabase();
     }
 
+    /**
+     * Make sure the Member doesn't create issue when editing a user
+     */
     public function testEditUser(): void
     {
         /** @var Member */
@@ -84,7 +87,7 @@ public function testEditUser(): void
     }
 
     /**
-     * Test index (`/users/u/{user_name}`) page.
+     * Test `/users/u/{user_name}` page.
      */
     public function testPage(): void
     {
@@ -108,6 +111,9 @@ public function testPage(): void
         $this->assertNotEmpty((string) $response->getBody());
     }
 
+    /**
+     * Test `/users/u/{user_name}` page forbidden exception
+     */
     public function testPageForForbiddenException(): void
     {
         /** @var Member */
@@ -122,4 +128,21 @@ public function testPageForForbiddenException(): void
         $this->assertJsonResponse('Access Denied', $response, 'title');
         $this->assertResponseStatus(403, $response);
     }
+
+    /**
+     * Test issue that arose when using the Member model with UserRoleSprunje
+     */
+    public function testUserRoleSprunje(): void
+    {
+        /** @var Member */
+        $user = Member::factory()->create();
+        $this->actAsUser($user, isMaster: true);
+
+        // Create request with method and url and fetch response
+        $request = $this->createJsonRequest('GET', "/api/users/u/{$user->user_name}/roles");
+        $response = $this->handleRequest($request);
+
+        // Assert status & response is not empty
+        $this->assertResponseStatus(200, $response);
+    }
 }