Updated tests

Author: eldadfux

src/CLI/CLI.php

@@ -41,7 +41,7 @@ class CLI {
      *
      * @var callable
      */
-    protected $error = null;
+    protected $error;
 
     /**
      * Init
@@ -75,7 +75,7 @@ public function __construct(array $args = [])
 
         $this->args = $this->parse((!empty($args) || !isset($_SERVER['argv'])) ? $args: $_SERVER['argv']);
 
-        $this->error = function (Exception $error) {
+        $this->error = function (Exception $error): void {
             Console::error($error->getMessage());
         };
 
@@ -87,10 +87,10 @@ public function __construct(array $args = [])
      *
      * Set a callback function that will be initialized on application start
      *
-     * @param $callback
+     * @param callable $callback
      * @return $this
      */
-    public function init($callback)
+    public function init(callable $callback): self
     {
         $this->init[] = $callback;
         return $this;
@@ -104,7 +104,7 @@ public function init($callback)
      * @param $callback
      * @return $this
      */
-    public function shutdown($callback)
+    public function shutdown(callable $callback): self
     {
         $this->shutdown[] = $callback;
         return $this;
@@ -118,13 +118,22 @@ public function shutdown($callback)
      * @param $callback
      * @return $this
      */
-    public function error($callback)
+    public function error(callable $callback): self
     {
         $this->error = $callback;
         return $this;
     }
 
-    public function task($name)
+    /**
+     * Task
+     * 
+     * Add a new command task
+     * 
+     * @param string $name
+     * 
+     * @return Task
+     */
+    public function task(string $name): Task
     {
         $task = new Task($name);
 
@@ -134,14 +143,13 @@ public function task($name)
     }
 
     /**
-     *
      * task-name --foo=test
      *
-     * @param $args
-     * @return mixed
+     * @param array $args
      * @throws Exception
+     * @return array
      */
-    public function parse(array $args)
+    public function parse(array $args): array
     {
         \array_shift($args); // Remove script path from args
 
@@ -167,8 +175,10 @@ public function parse(array $args)
 
     /**
      * Run
+     * 
+     * @return $this
      */
-    public function run()
+    public function run(): self
     {
         $command = isset($this->tasks[$this->command]) ? $this->tasks[$this->command] : null;
 
@@ -212,12 +222,12 @@ public function run()
      *
      * Creates an validator instance and validate given value with given rules.
      *
-     * @param $key
-     * @param $param
-     * @param $value
+     * @param string $key
+     * @param array $param
+     * @param mixed $value
      * @throws Exception
      */
-    protected function validate($key, $param, $value)
+    protected function validate(string $key, array $param, $value): void
     {
         if ('' !== $value) {
             // checking whether the class exists

src/CLI/Console.php

@@ -87,13 +87,13 @@ static public function warning(string $message)
      *
      * Log warning messages to console
      *
-     * @param string $message
-     * @return bool|int
+     * @param string $question
+     * @return string
      */
     static public function confirm(string $question)
     {
         if(!self::isInteractive()) {
-            return null;
+            return '';
         }
 
         self::log($question);
@@ -124,7 +124,7 @@ static public function exit(int $status = 0): void
      * 
      * This function was inspired by: https://stackoverflow.com/a/13287902/2299554
      */
-    static public function execute(string $cmd, string $stdin = null, string &$stdout, string &$stderr, int $timeout = -1): int
+    static public function execute(string $cmd, string $stdin = '', string &$stdout, string &$stderr, int $timeout = -1): int
     {
         $pipes = [];
         $process = \proc_open(
@@ -163,7 +163,7 @@ static public function execute(string $cmd, string $stdin = null, string &$stdou
                 \fclose($pipes[2]);
                 \proc_close($process);
 
-                return $status['exitcode'];
+                return (int)$status['exitcode'];
             }
 
             \usleep(100000);

src/CLI/Task.php

@@ -48,6 +48,7 @@ class Task
     public function __construct(string $name)
     {
         $this->name = $name;
+        $this->action = function(): void {};
     }
 
     /**

tests/CLI/CLITest.php

@@ -21,11 +21,11 @@
 
 class CLITest extends TestCase
 {
-    public function setUp()
+    public function setUp(): void
     {
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -69,7 +69,7 @@ public function testAppFailure()
         $this->assertEquals('', $result);
     }
 
-    public function testApp[]
+    public function testAppArray()
     {
         ob_start();
 

tests/CLI/ConsoleTest.php

@@ -18,11 +18,11 @@
 
 class ConsoleTest extends TestCase
 {
-    public function setUp()
+    public function setUp(): void
     {
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 

tests/CLI/TaskTest.php

@@ -24,12 +24,12 @@ class TaskTest extends TestCase
      */
     protected $task;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->task = new Task('test');
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         $this->task = null;
     }