Fix MongoDB transaction safety, tenant-aware dedup, and empty ID filtering

- Pre-filter duplicates inside MongoDB session instead of bypassing the
  transaction, ensuring ignore mode works correctly within transactions
- Use tenant-aware composite keys for intra-batch dedup in
  tenant-per-document mode
- Add array_filter() to tenant prefetch paths to skip empty IDs,
  consistent with non-tenant paths

Author: premtsd-code

src/Database/Adapter/Mongo.php

@@ -1463,14 +1463,7 @@ public function castingBefore(Document $collection, Document $document): Documen
     public function createDocuments(Document $collection, array $documents, bool $ignore = false): array
     {
         $name = $this->getNamespace() . '_' . $this->filter($collection->getId());
-
-        if ($ignore) {
-            // Run outside transaction — MongoDB aborts transactions on any write error,
-            // so ordered:false + session would roll back even successfully inserted docs.
-            $options = ['ordered' => false];
-        } else {
-            $options = $this->getTransactionOptions();
-        }
+        $options = $this->getTransactionOptions();
 
         $records = [];
         $hasSequence = null;
@@ -1494,19 +1487,42 @@ public function createDocuments(Document $collection, array $documents, bool $ig
             $records[] = $record;
         }
 
-        try {
-            $documents = $this->client->insertMany($name, $records, $options);
-        } catch (MongoException $e) {
-            $processed = $this->processException($e);
+        // In ignore mode, pre-filter duplicates within the same session to avoid
+        // BulkWriteException which would abort the transaction.
+        if ($ignore && !empty($records)) {
+            $uids = \array_filter(\array_map(fn ($r) => $r['_uid'] ?? null, $records));
+            if (!empty($uids)) {
+                $findOptions = $this->getTransactionOptions(['projection' => ['_uid' => 1]]);
+                $result = $this->client->find($name, ['_uid' => ['$in' => \array_values($uids)]], $findOptions);
+                $existingUids = [];
+                foreach ($result->cursor->firstBatch ?? [] as $doc) {
+                    $existingUids[$doc->_uid] = true;
+                }
 
-            if ($ignore && $processed instanceof DuplicateException) {
-                // Race condition: a doc was inserted between pre-filter and insertMany.
-                // With ordered:false outside transaction, non-duplicate inserts persist.
-                // Return empty — we cannot determine which docs succeeded without querying.
+                if (!empty($existingUids)) {
+                    $filteredRecords = [];
+                    $filteredDocuments = [];
+                    foreach ($records as $i => $record) {
+                        $uid = $record['_uid'] ?? '';
+                        if (!isset($existingUids[$uid])) {
+                            $filteredRecords[] = $record;
+                            $filteredDocuments[] = $documents[$i];
+                        }
+                    }
+                    $records = $filteredRecords;
+                    $documents = $filteredDocuments;
+                }
+            }
+
+            if (empty($records)) {
                 return [];
             }
+        }
 
-            throw $processed;
+        try {
+            $documents = $this->client->insertMany($name, $records, $options);
+        } catch (MongoException $e) {
+            throw $this->processException($e);
         }
 
         foreach ($documents as $index => $document) {

src/Database/Database.php

@@ -5655,18 +5655,24 @@ public function createDocuments(
         $time = DateTime::now();
         $modified = 0;
 
+        $tenantPerDocument = $this->adapter->getSharedTables() && $this->adapter->getTenantPerDocument();
+
         // Deduplicate intra-batch documents by ID when ignore mode is on.
         // Keeps the first occurrence, mirrors upsertDocuments' seenIds check.
+        // In tenant-per-document mode, dedupe by tenant+id to allow same ID across tenants.
         if ($ignore) {
             $seenIds = [];
             $deduplicated = [];
             foreach ($documents as $document) {
                 $docId = $document->getId();
-                if ($docId !== '' && isset($seenIds[$docId])) {
-                    continue;
-                }
                 if ($docId !== '') {
-                    $seenIds[$docId] = true;
+                    $dedupeKey = $tenantPerDocument
+                        ? $document->getTenant() . ':' . $docId
+                        : $docId;
+                    if (isset($seenIds[$dedupeKey])) {
+                        continue;
+                    }
+                    $seenIds[$dedupeKey] = true;
                 }
                 $deduplicated[] = $document;
             }
@@ -5676,15 +5682,14 @@ public function createDocuments(
         // When ignore mode is on and relationships are being resolved,
         // pre-fetch existing document IDs so we skip relationship writes for duplicates
         $preExistingIds = [];
-        $tenantPerDocument = $this->adapter->getSharedTables() && $this->adapter->getTenantPerDocument();
         if ($ignore) {
             if ($tenantPerDocument) {
                 $idsByTenant = [];
                 foreach ($documents as $doc) {
                     $idsByTenant[$doc->getTenant()][] = $doc->getId();
                 }
                 foreach ($idsByTenant as $tenant => $tenantIds) {
-                    $tenantIds = \array_values(\array_unique($tenantIds));
+                    $tenantIds = \array_values(\array_unique(\array_filter($tenantIds)));
                     foreach (\array_chunk($tenantIds, \max(1, $this->maxQueryValues)) as $idChunk) {
                         $existing = $this->authorization->skip(fn () => $this->withTenant($tenant, fn () => $this->silent(fn () => $this->find(
                             $collection->getId(),
@@ -7219,7 +7224,7 @@ public function upsertDocumentsWithIncrease(
                     $idsByTenant[$tenant][] = $doc->getId();
                 }
                 foreach ($idsByTenant as $tenant => $tenantIds) {
-                    $tenantIds = \array_values(\array_unique($tenantIds));
+                    $tenantIds = \array_values(\array_unique(\array_filter($tenantIds)));
                     foreach (\array_chunk($tenantIds, \max(1, $this->maxQueryValues)) as $idChunk) {
                         $fetched = $this->authorization->skip(fn () => $this->withTenant($tenant, fn () => $this->silent(fn () => $this->find(
                             $collection->getId(),