(fix): skip structure validation for internal metadata document updates

Metadata documents contain JSON-filtered fields (like attributes and
indexes) that are stored as strings but decoded to arrays of Document
objects. The Structure validator validates against the raw schema type
(string) but receives the decoded value (array), causing false
validation failures.

Wraps all updateDocument(self::METADATA, ...) calls in skipValidation()
since metadata document structure is controlled internally.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: abnegate

src/Database/Database.php

@@ -2248,7 +2248,7 @@ private function updateMetadata(
         try {
             if ($collection->getId() !== self::METADATA) {
                 $this->withRetries(
-                    fn () => $this->silent(fn () => $this->updateDocument(self::METADATA, $collection->getId(), $collection))
+                    fn () => $this->skipValidation(fn () => $this->silent(fn () => $this->updateDocument(self::METADATA, $collection->getId(), $collection)))
                 );
             }
         } catch (Throwable $e) {

src/Database/Traits/Collections.php

@@ -256,7 +256,7 @@ public function updateCollection(string $id, array $permissions, bool $documentS
             ->setAttribute('$permissions', $permissions)
             ->setAttribute('documentSecurity', $documentSecurity);
 
-        $collection = $this->silent(fn () => $this->updateDocument(self::METADATA, $collection->getId(), $collection));
+        $collection = $this->skipValidation(fn () => $this->silent(fn () => $this->updateDocument(self::METADATA, $collection->getId(), $collection)));
 
         $this->trigger(Event::CollectionUpdate, $collection);
 

src/Database/Traits/Relationships.php

@@ -294,10 +294,12 @@ public function createRelationship(
         $this->silent(function () use ($collection, $relatedCollection, $type, $twoWay, $id, $twoWayKey, $junctionCollection, $created) {
             $indexesCreated = [];
             try {
-                $this->withRetries(function () use ($collection, $relatedCollection) {
-                    $this->withTransaction(function () use ($collection, $relatedCollection) {
-                        $this->updateDocument(self::METADATA, $collection->getId(), $collection);
-                        $this->updateDocument(self::METADATA, $relatedCollection->getId(), $relatedCollection);
+                $this->skipValidation(function () use ($collection, $relatedCollection) {
+                    $this->withRetries(function () use ($collection, $relatedCollection) {
+                        $this->withTransaction(function () use ($collection, $relatedCollection) {
+                            $this->updateDocument(self::METADATA, $collection->getId(), $collection);
+                            $this->updateDocument(self::METADATA, $relatedCollection->getId(), $relatedCollection);
+                        });
                     });
                 });
             } catch (Throwable $e) {
@@ -369,7 +371,7 @@ public function createRelationship(
                 }
 
                 try {
-                    $this->withTransaction(function () use ($collection, $relatedCollection, $id, $twoWayKey) {
+                    $this->skipValidation(fn () => $this->withTransaction(function () use ($collection, $relatedCollection, $id, $twoWayKey) {
                         /** @var array<Document> $attributes */
                         $attributes = $collection->getAttribute('attributes', []);
                         $collection->setAttribute('attributes', array_filter($attributes, fn (Document $attr) => $attr->getId() !== $id));
@@ -379,7 +381,7 @@ public function createRelationship(
                         $relatedAttributes = $relatedCollection->getAttribute('attributes', []);
                         $relatedCollection->setAttribute('attributes', array_filter($relatedAttributes, fn (Document $attr) => $attr->getId() !== $twoWayKey));
                         $this->updateDocument(self::METADATA, $relatedCollection->getId(), $relatedCollection);
-                    });
+                    }));
                 } catch (Throwable $cleanupError) {
                     Console::error("Failed to cleanup metadata for relationship '{$id}': ".$cleanupError->getMessage());
                 }
@@ -910,11 +912,13 @@ public function deleteRelationship(string $collection, string $id): bool
         }
 
         try {
-            $this->withRetries(function () use ($collection, $relatedCollection) {
-                $this->silent(function () use ($collection, $relatedCollection) {
-                    $this->withTransaction(function () use ($collection, $relatedCollection) {
-                        $this->updateDocument(self::METADATA, $collection->getId(), $collection);
-                        $this->updateDocument(self::METADATA, $relatedCollection->getId(), $relatedCollection);
+            $this->skipValidation(function () use ($collection, $relatedCollection) {
+                $this->withRetries(function () use ($collection, $relatedCollection) {
+                    $this->silent(function () use ($collection, $relatedCollection) {
+                        $this->withTransaction(function () use ($collection, $relatedCollection) {
+                            $this->updateDocument(self::METADATA, $collection->getId(), $collection);
+                            $this->updateDocument(self::METADATA, $relatedCollection->getId(), $relatedCollection);
+                        });
                     });
                 });
             });