Skip to content

Commit f2b08dc

Browse files
committed
Remove int cast on MongoDB cursor IDs in getMore loop
1 parent f9fa1dd commit f2b08dc

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

src/Database/Adapter/Mongo.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1514,13 +1514,13 @@ public function createDocuments(Document $collection, array $documents, bool $ig
15141514
foreach ($response->cursor->firstBatch ?? [] as $doc) {
15151515
$existingKeys[$tenant . ':' . $doc->_uid] = true;
15161516
}
1517-
$cursorId = $response->cursor->id ?? null;
1518-
while ($cursorId && $cursorId !== 0) {
1519-
$more = $this->client->getMore((int)$cursorId, $name, \count($tenantUids));
1517+
$cursorId = $response->cursor->id ?? 0;
1518+
while ($cursorId != 0) {
1519+
$more = $this->client->getMore($cursorId, $name, \count($tenantUids));
15201520
foreach ($more->cursor->nextBatch ?? [] as $doc) {
15211521
$existingKeys[$tenant . ':' . $doc->_uid] = true;
15221522
}
1523-
$cursorId = (int)($more->cursor->id ?? 0);
1523+
$cursorId = $more->cursor->id ?? 0;
15241524
}
15251525
}
15261526
} else {
@@ -1539,13 +1539,13 @@ public function createDocuments(Document $collection, array $documents, bool $ig
15391539
foreach ($response->cursor->firstBatch ?? [] as $doc) {
15401540
$existingKeys[$doc->_uid] = true;
15411541
}
1542-
$cursorId = $response->cursor->id ?? null;
1543-
while ($cursorId && $cursorId !== 0) {
1544-
$more = $this->client->getMore((int)$cursorId, $name, \count($uidValues));
1542+
$cursorId = $response->cursor->id ?? 0;
1543+
while ($cursorId != 0) {
1544+
$more = $this->client->getMore($cursorId, $name, \count($uidValues));
15451545
foreach ($more->cursor->nextBatch ?? [] as $doc) {
15461546
$existingKeys[$doc->_uid] = true;
15471547
}
1548-
$cursorId = (int)($more->cursor->id ?? 0);
1548+
$cursorId = $more->cursor->id ?? 0;
15491549
}
15501550
}
15511551
}

0 commit comments

Comments
 (0)