Fix tests

Author: Meldiron

src/DNS/Zone/Resolver.php

@@ -44,14 +44,7 @@ public static function lookup(Message $query, Zone $zone): Message
         if (empty($records)) {
             // SOA is stored separately; if querying SOA at the zone apex, return it
             if ($question->type === Record::TYPE_SOA && $question->name === $zone->name) {
-                return Message::response(
-                    header: $query->header,
-                    responseCode: Message::RCODE_NOERROR,
-                    questions: $query->questions,
-                    answers: [$zone->soa],
-                    authoritative: true,
-                    recursionAvailable: false
-                );
+                return self::soaApexResponse($query, $zone);
             }
 
             return Message::response(
@@ -171,14 +164,7 @@ private static function handleExactMatch(array $records, Message $query, Zone $z
         if ($isAuthoritative) {
             // SOA is stored separately in Zone; handle SOA queries at the zone apex
             if ($question->type === Record::TYPE_SOA && $question->name === $zone->name) {
-                return Message::response(
-                    header: $query->header,
-                    responseCode: Message::RCODE_NOERROR,
-                    questions: $query->questions,
-                    answers: [$zone->soa],
-                    authoritative: true,
-                    recursionAvailable: false
-                );
+                return self::soaApexResponse($query, $zone);
             }
 
             // Path E1: Exact match of type
@@ -239,6 +225,21 @@ private static function handleExactMatch(array $records, Message $query, Zone $z
         }
     }
 
+    /**
+     * Build an authoritative SOA answer for the zone apex.
+     */
+    private static function soaApexResponse(Message $query, Zone $zone): Message
+    {
+        return Message::response(
+            header: $query->header,
+            responseCode: Message::RCODE_NOERROR,
+            questions: $query->questions,
+            answers: [$zone->soa],
+            authoritative: true,
+            recursionAvailable: false
+        );
+    }
+
     /**
      * Randomize RRSet order for load balancing.
      *

tests/e2e/DNS/ClientTest.php

@@ -213,16 +213,16 @@ public function testSoaRecords(): void
         $response = $client->query(Message::query(
             new Question('appwrite.io', Record::TYPE_SOA)
         ));
-        $this->assertCount(0, $response->answers);
+        $this->assertCount(0, $response->authority);
 
-        $authority = $response->authority;
-        $this->assertCount(1, $authority);
-        $this->assertSame('appwrite.io', $authority[0]->name);
-        $this->assertSame(Record::CLASS_IN, $authority[0]->class);
-        $this->assertSame(30, $authority[0]->ttl);
-        $this->assertSame(Record::TYPE_SOA, $authority[0]->type);
+        $answers = $response->answers;
+        $this->assertCount(1, $answers);
+        $this->assertSame('appwrite.io', $answers[0]->name);
+        $this->assertSame(Record::CLASS_IN, $answers[0]->class);
+        $this->assertSame(30, $answers[0]->ttl);
+        $this->assertSame(Record::TYPE_SOA, $answers[0]->type);
 
-        $rdata = $authority[0]->rdata;
+        $rdata = $answers[0]->rdata;
         $this->assertStringContainsString('ns1.appwrite.zone', $rdata);
         $this->assertStringContainsString('team.appwrite.io', $rdata);
         $this->assertStringContainsString('1 7200 1800 1209600 3600', $rdata);