Skip to content

Commit 42e64bf

Browse files
committed
Skip snapshot tests
These tests create node snapshots even when node snapshots are disabled. Node snapshots don't work at the moment because FunctionTemplateInfo objects with fast API callbacks are put into the snapshot. However, the way FunctionTemplateInfo objects reference fast API callbacks at the moment causes security issues, and the fix references fast API callbacks via a dynamically allocated C++ object, which cannot be put into the snapshot.
1 parent 8209a15 commit 42e64bf

1 file changed

Lines changed: 35 additions & 0 deletions

File tree

test/parallel/parallel.status

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,41 @@ test-async-context-frame: SKIP
110110
test-fs-stat-bigint: SKIP
111111
test-sqlite-session: SKIP
112112

113+
# These tests create node snapshots even when node snapshots are disabled.
114+
# Node snapshots don't work at the moment because FunctionTemplateInfo
115+
# objects with fast API callbacks are put into the snapshot. However, the way
116+
# FunctionTemplateInfo objects reference fast API callbacks at the moment causes
117+
# security issues, and the fix references fast API callbacks via a dynamically
118+
# allocated C++ object, which cannot be put into the snapshot.
119+
test-snapshot-stack-trace-limit-mutation: SKIP
120+
test-inspect-address-in-use: SKIP
121+
test-snapshot-api: SKIP
122+
test-snapshot-argv1: SKIP
123+
test-snapshot-basic: SKIP
124+
test-snapshot-child-process-sync: SKIP
125+
test-snapshot-cjs-main: SKIP
126+
test-snapshot-config: SKIP
127+
test-snapshot-console: SKIP
128+
test-snapshot-coverage: SKIP
129+
test-snapshot-cwd: SKIP
130+
test-snapshot-error: SKIP
131+
test-snapshot-eval: SKIP
132+
test-snapshot-gzip: SKIP
133+
test-snapshot-incompatible: SKIP
134+
test-snapshot-net: SKIP
135+
test-snapshot-reproducible: SKIP
136+
test-snapshot-stack-trace-limit: SKIP
137+
test-snapshot-typescript: SKIP
138+
test-snapshot-umd: SKIP
139+
test-snapshot-warning: SKIP
140+
test-snapshot-weak-reference: SKIP
141+
test-snapshot-worker: SKIP
142+
test-snapshot-namespaced-builtin: SKIP
143+
test-snapshot-dns-resolve-localhost: SKIP
144+
test-snapshot-dns-lookup-localhost: SKIP
145+
test-snapshot-dns-lookup-localhost-promise: SKIP
146+
test-snapshot-dns-resolve-localhost-promise: SKIP
147+
113148
[$system==win32]
114149

115150
# Until V8 provides a better way to check for flag mismatch without

0 commit comments

Comments
 (0)