chore(mocks-in-e2e0tests): apply prettier & minor changes

Kamil Gajowy · Sikora00 · commit 9c2404a6368c · 2021-07-09T09:36:36.000+02:00
diff --git a/articles/mocks-in-e2e-tests/src/app.module.ts b/articles/mocks-in-e2e-tests/src/app.module.ts
@@ -1,8 +1,7 @@
-import {Module} from '@nestjs/common';
-import {OrdersModule} from "./orders";
+import { Module } from '@nestjs/common';
+import { OrdersModule } from './orders';
 
 @Module({
-    imports: [OrdersModule],
+  imports: [OrdersModule],
 })
-export class AppModule {
-}
+export class AppModule {}
diff --git a/articles/mocks-in-e2e-tests/src/orders/controller.ts b/articles/mocks-in-e2e-tests/src/orders/controller.ts
@@ -1,30 +1,24 @@
-import {Body, Controller, Get, Param, Post} from "@nestjs/common";
-import {ApiNoContentResponse} from "@nestjs/swagger";
-import {OrderDto} from "./order.dto";
-import {Service, PaymentStatus} from "./service";
+import { Body, Controller, Get, Param, Post } from '@nestjs/common';
+import { ApiNoContentResponse } from '@nestjs/swagger';
+import { OrderDto } from './order.dto';
+import { Service, PaymentStatus } from './service';
 
 @Controller()
 export class OrdersController {
+  constructor(private readonly gateway: Service) {}
 
-    constructor(
-        private readonly gateway: Service
-    ) {
-    }
+  @ApiNoContentResponse()
+  @Post()
+  async createOrder(@Body() body: OrderDto): Promise<void> {
+    return this.gateway.createOrder(body.uuid);
+  }
 
-    @ApiNoContentResponse()
-    @Post()
-    async createOrder(
-        @Body() body: OrderDto
-    ): Promise<void> {
-        return this.gateway.createOrder(body.uuid);
-    }
-
-    @Get(`:id`)
-    async getOrderStatus(
-        @Param("id") orderId: string
-    ): Promise<{ status: PaymentStatus }> {
-        return {
-            status: await this.gateway.getOrderStatus(orderId)
-        };
-    }
-}
+  @Get(`:id`)
+  async getOrderStatus(
+    @Param('id') orderId: string,
+  ): Promise<{ status: PaymentStatus }> {
+    return {
+      status: await this.gateway.getOrderStatus(orderId),
+    };
+  }
+}
diff --git a/articles/mocks-in-e2e-tests/src/orders/index.ts b/articles/mocks-in-e2e-tests/src/orders/index.ts
@@ -1,4 +1,4 @@
-export {OrdersModule} from "./module";
+export { OrdersModule } from './module';
 
-export {PaymentStatus} from "./service";
-export {OrderDto} from "./order.dto";
+export { PaymentStatus } from './service';
+export { OrderDto } from './order.dto';
diff --git a/articles/mocks-in-e2e-tests/src/orders/module.ts b/articles/mocks-in-e2e-tests/src/orders/module.ts
@@ -1,11 +1,10 @@
-import { HttpModule, Module } from "@nestjs/common";
-import { Service } from "./service";
-import { OrdersController } from "./controller";
+import { HttpModule, Module } from '@nestjs/common';
+import { Service } from './service';
+import { OrdersController } from './controller';
 
 @Module({
   imports: [HttpModule],
   providers: [Service],
-  controllers: [OrdersController]
+  controllers: [OrdersController],
 })
-export class OrdersModule {
-}
+export class OrdersModule {}
diff --git a/articles/mocks-in-e2e-tests/src/orders/order.dto.ts b/articles/mocks-in-e2e-tests/src/orders/order.dto.ts
@@ -1,8 +1,7 @@
-import { IsDefined, IsString } from "class-validator";
+import { IsDefined, IsString } from 'class-validator';
 
 export class OrderDto {
   @IsString()
   @IsDefined()
-  uuid!: string
+  uuid!: string;
 }
-
diff --git a/articles/mocks-in-e2e-tests/src/orders/service.ts b/articles/mocks-in-e2e-tests/src/orders/service.ts
@@ -1,40 +1,37 @@
-import { HttpService, Injectable } from "@nestjs/common";
+import { HttpService, Injectable } from '@nestjs/common';
 
 export enum PaymentStatus {
   Started,
   Pending,
   Rejected,
-  Approved
+  Approved,
 }
 
 @Injectable()
 export class Service {
+  /**
+   * for brevity, skip real configs
+   */
+  private paymentServiceUrl = process.env.PAYMENT_GATEWAY ?? ""
 
-  constructor(
-    private readonly httpService: HttpService
-  ) {
-  }
+  constructor(private readonly httpService: HttpService) {}
 
   async createOrder(
     uuid: string,
-    /**
-     * for brevity, skip real configs
-     */
-    paymentServiceUrl = process.env.PAYMENT_GATEWAY ?? ""
   ): Promise<void> {
-    await this.httpService.post(paymentServiceUrl, {
-      uuid,
-    }).toPromise();
+    await this.httpService
+      .post(this.paymentServiceUrl, {
+        uuid,
+      })
+      .toPromise();
   }
 
   async getOrderStatus(
-    uuid: string,
-    /**
-     * for brevity, skip real configs
-     */
-    paymentServiceUrl = process.env.PAYMENT_GATEWAY ?? ""
+    uuid: string
   ): Promise<PaymentStatus> {
-    const { status } = (await this.httpService.get(paymentServiceUrl + `/${uuid}`).toPromise()).data;
+    const { status } = (
+      await this.httpService.get(this.paymentServiceUrl + `/${uuid}`).toPromise()
+    ).data;
     return status as PaymentStatus;
-  };
-}
+  }
+}
diff --git a/articles/mocks-in-e2e-tests/test/order-base-example-without-mock.e2e-spec.ts b/articles/mocks-in-e2e-tests/test/order-base-example-without-mock.e2e-spec.ts
@@ -1,34 +1,34 @@
-import { INestApplication } from "@nestjs/common";
-import { Test } from "@nestjs/testing";
-import * as request from "supertest";
+import { INestApplication } from '@nestjs/common';
+import { Test } from '@nestjs/testing';
+import * as request from 'supertest';
 
-import {OrdersModule, PaymentStatus} from "../src/orders";
+import { OrdersModule, PaymentStatus } from '../src/orders';
 
 let app: INestApplication;
 
 /**
  * for brevity
  */
-const paymentGatewayUrl = "http://localhost:1337"
-process.env.PAYMENT_GATEWAY = paymentGatewayUrl
+const paymentGatewayUrl = 'http://localhost:1337';
+process.env.PAYMENT_GATEWAY = paymentGatewayUrl;
 
 beforeAll(async () => {
   const moduleFixture = await Test.createTestingModule({
-    imports: [OrdersModule]
+    imports: [OrdersModule],
   }).compile();
 
   app = moduleFixture.createNestApplication();
   await app.init();
 });
 
 describe.skip(`when order was submitted`, () => {
-  const uuid = "test-order-uuid";
+  const uuid = 'test-order-uuid';
 
-  it("should ACK the order", () => {
+  it('should ACK the order', () => {
     return request(app.getHttpServer())
-      .post("/")
+      .post('/')
       .send({
-        uuid
+        uuid,
       })
       .expect(201);
   });
@@ -48,11 +48,10 @@ describe.skip(`when order was submitted`, () => {
         return request(app.getHttpServer())
           .get(`/${uuid}`)
           .expect(200)
-          .then(res => {
+          .then((res) => {
             expect(res.body.status).toEqual(PaymentStatus.Approved);
           });
       });
     });
   });
-
-});
+});
diff --git a/articles/mocks-in-e2e-tests/test/order-fake-service.e2e-spec.ts b/articles/mocks-in-e2e-tests/test/order-fake-service.e2e-spec.ts
@@ -1,41 +1,45 @@
-import { INestApplication } from "@nestjs/common";
-import { Test } from "@nestjs/testing";
-import * as request from "supertest";
+import { INestApplication } from '@nestjs/common';
+import { Test } from '@nestjs/testing';
+import * as request from 'supertest';
 
-import {OrdersModule, PaymentStatus} from "../src/orders";
+import { OrdersModule, PaymentStatus } from '../src/orders';
 
-import {start, shutdown, confirmOrder} from "./payment-gateway-fake/bootstrap"
+import {
+  start,
+  shutdown,
+  confirmOrder,
+} from './payment-gateway-fake/bootstrap';
 
 let app: INestApplication;
 
 /**
  * for brevity
  */
-const paymentGatewayUrl = "http://localhost:1337";
+const paymentGatewayUrl = 'http://localhost:1337';
 process.env.PAYMENT_GATEWAY = paymentGatewayUrl;
 
 beforeAll(async () => {
-  process.env.PAYMENT_GATEWAY = await start(1337)
+  process.env.PAYMENT_GATEWAY = await start(1337);
   const moduleFixture = await Test.createTestingModule({
-    imports: [OrdersModule]
+    imports: [OrdersModule],
   }).compile();
 
   app = moduleFixture.createNestApplication();
   await app.init();
 });
 
 afterAll(async () => {
-  await app.close()
-  await shutdown()
-})
+  await app.close();
+  await shutdown();
+});
 
 describe(`when order was submitted`, () => {
-  const uuid = "test-order-uuid";
-  it("should ACK the order", () => {
+  const uuid = 'test-order-uuid';
+  it('should ACK the order', () => {
     return request(app.getHttpServer())
-      .post("/")
+      .post('/')
       .send({
-        uuid
+        uuid,
       })
       .expect(201);
   });
@@ -51,20 +55,18 @@ describe(`when order was submitted`, () => {
     });
 
     describe(`when asking for a status after it was completed`, () => {
-
       beforeEach(() => {
-        confirmOrder(uuid) // clear intention
-      })
+        confirmOrder(uuid); // clear intention
+      });
 
       it(`should return \`approved\` state`, () => {
         return request(app.getHttpServer())
           .get(`/${uuid}`)
           .expect(200)
-          .then(res => {
+          .then((res) => {
             expect(res.body.status).toEqual(PaymentStatus.Approved);
           });
       });
     });
   });
-
-});
+});
diff --git a/articles/mocks-in-e2e-tests/test/order-mock-axios.e2e-spec.ts b/articles/mocks-in-e2e-tests/test/order-mock-axios.e2e-spec.ts
@@ -1,35 +1,35 @@
-import { INestApplication } from "@nestjs/common";
-import { Test } from "@nestjs/testing";
-import * as request from "supertest";
-import AxiosMockAdapter from "axios-mock-adapter";
+import { INestApplication } from '@nestjs/common';
+import { Test } from '@nestjs/testing';
+import * as request from 'supertest';
+import AxiosMockAdapter from 'axios-mock-adapter';
 
-import {OrdersModule, PaymentStatus} from "../src/orders";
+import { OrdersModule, PaymentStatus } from '../src/orders';
 
 let app: INestApplication;
 let axiosMock: AxiosMockAdapter;
 
 /**
  * for brevity
  */
-const paymentGatewayUrl = "http://localhost:1337";
+const paymentGatewayUrl = 'http://localhost:1337';
 process.env.PAYMENT_GATEWAY = paymentGatewayUrl;
 
 beforeAll(async () => {
   const moduleFixture = await Test.createTestingModule({
-    imports: [OrdersModule]
+    imports: [OrdersModule],
   }).compile();
 
   app = moduleFixture.createNestApplication();
   await app.init();
 
   // bind interceptor, force throw on any non-mocked route
-  axiosMock = new AxiosMockAdapter(app.get("AXIOS_INSTANCE_TOKEN"), {
-    onNoMatch: "throwException"
+  axiosMock = new AxiosMockAdapter(app.get('AXIOS_INSTANCE_TOKEN'), {
+    onNoMatch: 'throwException',
   });
 });
 
 describe(`when order was submitted`, () => {
-  const uuid = "test-order-uuid";
+  const uuid = 'test-order-uuid';
 
   beforeEach(() => {
     // "configure" responses
@@ -40,19 +40,19 @@ describe(`when order was submitted`, () => {
       .replyOnce(200, {})
       .onGet(paymentGatewayUrl + `/${uuid}`)
       .replyOnce(200, {
-        status: PaymentStatus.Pending
+        status: PaymentStatus.Pending,
       })
       .onGet(paymentGatewayUrl + `/${uuid}`)
       .replyOnce(200, {
-        status: PaymentStatus.Approved
+        status: PaymentStatus.Approved,
       });
   });
 
-  it("should ACK the order", () => {
+  it('should ACK the order', () => {
     return request(app.getHttpServer())
-      .post("/")
+      .post('/')
       .send({
-        uuid
+        uuid,
       })
       .expect(201);
   });
@@ -72,11 +72,10 @@ describe(`when order was submitted`, () => {
         return request(app.getHttpServer())
           .get(`/${uuid}`)
           .expect(200)
-          .then(res => {
+          .then((res) => {
             expect(res.body.status).toEqual(PaymentStatus.Approved);
           });
       });
     });
   });
-
-});
+});
diff --git a/articles/mocks-in-e2e-tests/test/payment-gateway-fake/app.module.ts b/articles/mocks-in-e2e-tests/test/payment-gateway-fake/app.module.ts
diff --git a/articles/mocks-in-e2e-tests/test/payment-gateway-fake/bootstrap.ts b/articles/mocks-in-e2e-tests/test/payment-gateway-fake/bootstrap.ts
