Merge pull request #79 from jfredon/update-for-php84-deprecations

Fix PHP 8.4 deprecation notices updating type hints and improving test assertions

Author: vanderlee

composer.json

@@ -22,7 +22,7 @@
     "source": "https://github.com/vanderlee/phpSyllable/"
   },
   "require": {
-    "php": ">=5.6",
+    "php": ">=7.1",
     "ext-json": "*",
     "ext-libxml": "*",
     "ext-mbstring": "*",

src/Syllable.php

@@ -176,7 +176,7 @@ public function getHyphen()
     /**
      * @param Cache $cache
      */
-    public function setCache(Cache $cache = null)
+    public function setCache(?Cache $cache = null)
     {
         $this->cache = $cache;
     }
@@ -612,8 +612,8 @@ private function parseHtmlText($html)
      */
     private function hyphenateHtmlDom(
         DOMNode $node,
-        DOMNodeList $excludeNodes = null,
-        DOMNodeList $includeNodes = null,
+        ?DOMNodeList $excludeNodes = null,
+        ?DOMNodeList $includeNodes = null,
         $split = true
     ) {
         if ($node->hasChildNodes()) {

tests/src/SyllableTest.php

@@ -189,8 +189,8 @@ public function testCache($cacheClass, $language, $cacheDirectory, $cacheFile, $
         $this->assertNotEmpty($this->object->getCache()->__get('patterns'));
         $this->assertGreaterThan(0, $this->object->getCache()->__get('max_pattern'));
         $this->assertNotEmpty($this->object->getCache()->__get('hyphenation'));
-        $this->assertInternalType('int', $this->object->getCache()->__get('left_min_hyphen'));
-        $this->assertInternalType('int', $this->object->getCache()->__get('right_min_hyphen'));
+        $this->assertIsInt($this->object->getCache()->__get('left_min_hyphen'));
+        $this->assertIsInt($this->object->getCache()->__get('right_min_hyphen'));
     }
 
     public function dataCacheVersionMatchesCacheFileVersionIsRelaxed()