Skip to content

Commit dae7e96

Browse files
committed
test(docs[sphinx_fonts]): fix mypy errors in test_sphinx_fonts
why: CI mypy fails with unused-ignore (sphinx_fonts is untyped) and duplicate module (docs/_ext/conftest.py conflicts with root conftest.py). what: - Remove all type: ignore[arg-type] comments from test_sphinx_fonts.py - Remove docs/_ext/conftest.py (not needed, sphinx_fonts has no doctests)
1 parent 8c73b49 commit dae7e96

2 files changed

Lines changed: 13 additions & 23 deletions

File tree

docs/_ext/conftest.py

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/docs/_ext/test_sphinx_fonts.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -213,14 +213,14 @@ def _make_app(
213213
def test_on_builder_inited_non_html(tmp_path: pathlib.Path) -> None:
214214
"""_on_builder_inited returns early for non-HTML builders."""
215215
app = _make_app(tmp_path, builder_format="latex")
216-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
216+
sphinx_fonts._on_builder_inited(app)
217217
assert not hasattr(app, "_font_faces")
218218

219219

220220
def test_on_builder_inited_empty_fonts(tmp_path: pathlib.Path) -> None:
221221
"""_on_builder_inited returns early when no fonts configured."""
222222
app = _make_app(tmp_path, fonts=[])
223-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
223+
sphinx_fonts._on_builder_inited(app)
224224
assert not hasattr(app, "_font_faces")
225225

226226

@@ -247,7 +247,7 @@ def test_on_builder_inited_with_fonts(
247247
for weight in [400, 700]:
248248
(cache / f"open-sans-latin-{weight}-normal.woff2").write_bytes(b"data")
249249

250-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
250+
sphinx_fonts._on_builder_inited(app)
251251

252252
assert len(app._font_faces) == 2
253253
assert app._font_faces[0]["family"] == "Open Sans"
@@ -283,7 +283,7 @@ def fake_urlretrieve(url: str, filename: t.Any) -> t.NoReturn:
283283
]
284284
app = _make_app(tmp_path, fonts=fonts)
285285

286-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
286+
sphinx_fonts._on_builder_inited(app)
287287

288288
assert len(app._font_faces) == 1
289289
assert app._font_faces[0]["family"] == "Inter"
@@ -312,7 +312,7 @@ def test_on_builder_inited_explicit_subset(
312312
cache.mkdir(parents=True)
313313
(cache / "noto-sans-latin-ext-400-normal.woff2").write_bytes(b"data")
314314

315-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
315+
sphinx_fonts._on_builder_inited(app)
316316

317317
assert app._font_faces[0]["filename"] == "noto-sans-latin-ext-400-normal.woff2"
318318

@@ -340,7 +340,7 @@ def test_on_builder_inited_preload_match(
340340
cache.mkdir(parents=True)
341341
(cache / "open-sans-latin-400-normal.woff2").write_bytes(b"data")
342342

343-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
343+
sphinx_fonts._on_builder_inited(app)
344344

345345
assert app._font_preload_hrefs == ["open-sans-latin-400-normal.woff2"]
346346

@@ -368,7 +368,7 @@ def test_on_builder_inited_preload_no_match(
368368
cache.mkdir(parents=True)
369369
(cache / "open-sans-latin-400-normal.woff2").write_bytes(b"data")
370370

371-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
371+
sphinx_fonts._on_builder_inited(app)
372372

373373
assert app._font_preload_hrefs == []
374374

@@ -397,7 +397,7 @@ def test_on_builder_inited_fallbacks_and_variables(
397397
cache.mkdir(parents=True)
398398
(cache / "inter-latin-400-normal.woff2").write_bytes(b"data")
399399

400-
sphinx_fonts._on_builder_inited(app) # type: ignore[arg-type]
400+
sphinx_fonts._on_builder_inited(app)
401401

402402
assert app._font_fallbacks == fallbacks
403403
assert app._font_css_variables == variables
@@ -428,7 +428,7 @@ def test_on_html_page_context_with_attrs() -> None:
428428
"index",
429429
"page.html",
430430
context,
431-
None, # type: ignore[arg-type]
431+
None,
432432
)
433433

434434
assert context["font_preload_hrefs"] == ["font-400.woff2"]
@@ -447,7 +447,7 @@ def test_on_html_page_context_without_attrs() -> None:
447447
"index",
448448
"page.html",
449449
context,
450-
None, # type: ignore[arg-type]
450+
None,
451451
)
452452

453453
assert context["font_preload_hrefs"] == []
@@ -471,7 +471,7 @@ def test_setup_return_value() -> None:
471471
connect=lambda event, handler: connections.append((event, handler)),
472472
)
473473

474-
result = sphinx_fonts.setup(app) # type: ignore[arg-type]
474+
result = sphinx_fonts.setup(app)
475475

476476
assert result == {
477477
"version": "1.0",
@@ -492,7 +492,7 @@ def test_setup_config_values() -> None:
492492
connect=lambda event, handler: connections.append((event, handler)),
493493
)
494494

495-
sphinx_fonts.setup(app) # type: ignore[arg-type]
495+
sphinx_fonts.setup(app)
496496

497497
config_names = [c[0] for c in config_values]
498498
assert "sphinx_fonts" in config_names
@@ -514,7 +514,7 @@ def test_setup_event_connections() -> None:
514514
connect=lambda event, handler: connections.append((event, handler)),
515515
)
516516

517-
sphinx_fonts.setup(app) # type: ignore[arg-type]
517+
sphinx_fonts.setup(app)
518518

519519
event_names = [c[0] for c in connections]
520520
assert "builder-inited" in event_names

0 commit comments

Comments
 (0)