fix: correct plugin behavior

Author: aooohan

internal/base/interfaces.go

@@ -251,6 +251,8 @@ func (p *Package) Clone() *Package {
 	}
 }
 
+var ErrNoResultProvide = errors.New("no result provided")
+
 type Plugin interface {
 	Available(ctx *AvailableHookCtx) ([]*AvailableHookResultItem, error)
 

internal/plugin/luai/plugin.go

@@ -38,10 +38,10 @@ func (l *LuaPlugin) Available(ctx *base.AvailableHookCtx) ([]*base.AvailableHook
 		return nil, err
 	}
 	if table == nil || table.Type() == lua.LTNil {
-		return nil, errors.New("no result provided")
+		return nil, base.ErrNoResultProvide
 	}
 
-	hookResult := []*base.AvailableHookResultItem{}
+	var hookResult []*base.AvailableHookResultItem
 	err = Unmarshal(table, &hookResult)
 	if err != nil {
 		return nil, errors.New("failed to unmarshal the return value: " + err.Error())
@@ -60,7 +60,7 @@ func (l *LuaPlugin) PreInstall(ctx *base.PreInstallHookCtx) (*base.PreInstallHoo
 		return nil, err
 	}
 	if table == nil || table.Type() == lua.LTNil {
-		return nil, errors.New("no result provided")
+		return nil, base.ErrNoResultProvide
 	}
 	hookResult := base.PreInstallHookResult{}
 	err = Unmarshal(table, &hookResult)
@@ -81,7 +81,7 @@ func (l *LuaPlugin) EnvKeys(ctx *base.EnvKeysHookCtx) ([]*base.EnvKeysHookResult
 		return nil, err
 	}
 	if table == nil || table.Type() == lua.LTNil || table.Len() == 0 {
-		return nil, fmt.Errorf("no environment variables provided")
+		return nil, base.ErrNoResultProvide
 	}
 
 	var hookResult []*base.EnvKeysHookResultItem
@@ -103,7 +103,7 @@ func (l *LuaPlugin) PreUse(ctx *base.PreUseHookCtx) (*base.PreUseHookResult, err
 		return nil, err
 	}
 	if table == nil || table.Type() == lua.LTNil {
-		return nil, errors.New("no result provided")
+		return nil, base.ErrNoResultProvide
 	}
 	hookResult := base.PreUseHookResult{}
 	err = Unmarshal(table, &hookResult)
@@ -144,7 +144,7 @@ func (l *LuaPlugin) ParseLegacyFile(ctx *base.ParseLegacyFileHookCtx) (*base.Par
 		return nil, err
 	}
 	if table == nil || table.Type() == lua.LTNil {
-		return nil, errors.New("no result provided")
+		return nil, base.ErrNoResultProvide
 	}
 	hookResult := base.ParseLegacyFileResult{}
 	err = Unmarshal(table, &hookResult)

internal/plugin/plugin.go

@@ -110,12 +110,13 @@ func (l *PluginWrapper) invokeAvailable(args []string) ([]*base.Package, error)
 		Args: args,
 	}
 	hookResult, err := l.impl.Available(&ctx)
+	if l.isNoResultProvided(err) {
+		return []*base.Package{}, nil
+	}
+
 	if err != nil {
 		return nil, err
 	}
-	if hookResult == nil {
-		return []*base.Package{}, nil
-	}
 
 	var result []*base.Package
 	for _, item := range hookResult {
@@ -200,12 +201,12 @@ func (l *PluginWrapper) PreInstall(version base.Version) (*base.Package, error)
 	}
 
 	result, err := l.impl.PreInstall(&ctx)
+	if l.isNoResultProvided(err) {
+		return &base.Package{}, nil
+	}
 	if err != nil {
 		return nil, err
 	}
-	if result == nil {
-		return &base.Package{}, nil
-	}
 
 	mainSdk, err := result.Info()
 	if err != nil {
@@ -264,12 +265,12 @@ func (l *PluginWrapper) EnvKeys(sdkPackage *base.Package) (*env.Envs, error) {
 
 	logger.Debugf("EnvKeysHookCtx: %+v \n", ctx)
 	items, err := l.impl.EnvKeys(ctx)
+	if l.isNoResultProvided(err) {
+		return nil, fmt.Errorf("no environment variables provided")
+	}
 	if err != nil {
 		return nil, err
 	}
-	if len(items) == 0 {
-		return nil, fmt.Errorf("no environment variables provided")
-	}
 
 	envKeys := &env.Envs{
 		Variables: make(env.Vars),
@@ -312,6 +313,11 @@ func (l *PluginWrapper) PreUse(version base.Version, previousVersion base.Versio
 	logger.Debugf("PreUseHookCtx: %+v \n", ctx)
 
 	result, err := l.impl.PreUse(&ctx)
+
+	if l.isNoResultProvided(err) {
+		return "", nil
+	}
+
 	if err != nil {
 		return "", err
 	}
@@ -369,6 +375,10 @@ func (l *PluginWrapper) PreUninstall(p *base.Package) error {
 	return l.impl.PreUninstall(ctx)
 }
 
+func (l *PluginWrapper) isNoResultProvided(err error) bool {
+	return errors.Is(err, base.ErrNoResultProvide)
+}
+
 func IsLuaPluginDir(pluginDirPath string) bool {
 	metadataPath := filepath.Join(pluginDirPath, "metadata.lua")
 	if util.FileExists(metadataPath) {