fix: storage.sdkPath configuration being ignored (#601)

* Initial plan

* Fix storage.sdkPath configuration not being applied

- Add ApplyStoragePath method to PathMeta to update Installs path from config
- Update NewSdkManager to apply storage.sdkPath after loading config
- Add unit tests for ApplyStoragePath functionality
- Fixes issue where storage.sdkPath in config.yaml was ignored

Co-authored-by: aooohan <40265686+aooohan@users.noreply.github.com>

* Address code review: improve test to use dynamic path suffix

- Import filepath in path_meta_test.go
- Update test to derive expected suffix from NewPathMeta instead of hardcoding
- Makes test more robust to changes in installedDirPrefix constant

Co-authored-by: aooohan <40265686+aooohan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: aooohan <40265686+aooohan@users.noreply.github.com>

Author: Copilot

internal/manager.go

@@ -781,6 +781,13 @@ func NewSdkManager() (*Manager, error) {
 		return nil, fmt.Errorf("load config failed: %w", err)
 	}
 
+	// Apply storage.sdkPath from config to PathMeta
+	if c.Storage != nil && c.Storage.SdkPath != "" {
+		if err := meta.ApplyStoragePath(c.Storage.SdkPath); err != nil {
+			return nil, fmt.Errorf("failed to apply storage path: %w", err)
+		}
+	}
+
 	return &Manager{
 		RuntimeEnvContext: &env.RuntimeEnvContext{
 			UserConfig:        c,

internal/pathmeta/path_meta.go

@@ -171,3 +171,21 @@ func getExecutablePath() string {
 	}
 	return exePath
 }
+
+// ApplyStoragePath applies the storage path from config to update the Installs path
+// If storagePath is empty, the current Installs path is unchanged
+func (p *PathMeta) ApplyStoragePath(storagePath string) error {
+	if storagePath == "" {
+		return nil
+	}
+	
+	// Update the Installs path to use the configured storage path
+	p.Shared.Installs = filepath.Join(storagePath, installedDirPrefix)
+	
+	// Ensure the directory exists
+	if err := os.MkdirAll(p.Shared.Installs, ReadWriteAuth); err != nil {
+		return fmt.Errorf("failed to create storage directory: %w", err)
+	}
+	
+	return nil
+}

internal/pathmeta/path_meta_test.go

@@ -19,6 +19,7 @@
 package pathmeta
 
 import (
+	"path/filepath"
 	"runtime"
 	"testing"
 )
@@ -155,3 +156,48 @@ func TestContainsPathSegment(t *testing.T) {
 		})
 	}
 }
+
+func TestApplyStoragePath(t *testing.T) {
+	// Create a temporary directory for testing
+	tmpDir := t.TempDir()
+	
+	// Create a PathMeta instance with default paths
+	meta := &PathMeta{
+		Shared: SharedPaths{
+			Root:     tmpDir,
+			Installs: tmpDir + "/default/cache",
+		},
+	}
+	
+	t.Run("Empty storage path does not change Installs", func(t *testing.T) {
+		originalInstalls := meta.Shared.Installs
+		err := meta.ApplyStoragePath("")
+		if err != nil {
+			t.Errorf("ApplyStoragePath with empty path should not error: %v", err)
+		}
+		if meta.Shared.Installs != originalInstalls {
+			t.Errorf("Installs path changed when it shouldn't: got %q, want %q", meta.Shared.Installs, originalInstalls)
+		}
+	})
+	
+	t.Run("Valid storage path updates Installs", func(t *testing.T) {
+		customPath := tmpDir + "/custom"
+		
+		// Create a reference PathMeta to get the expected suffix
+		refMeta, err := NewPathMeta(tmpDir, customPath, tmpDir, 1)
+		if err != nil {
+			t.Fatalf("Failed to create reference PathMeta: %v", err)
+		}
+		expectedSuffix := filepath.Base(refMeta.Shared.Installs)
+		
+		// Now test ApplyStoragePath
+		err = meta.ApplyStoragePath(customPath)
+		if err != nil {
+			t.Errorf("ApplyStoragePath with valid path should not error: %v", err)
+		}
+		expectedPath := filepath.Join(customPath, expectedSuffix)
+		if meta.Shared.Installs != expectedPath {
+			t.Errorf("Installs path not updated correctly: got %q, want %q", meta.Shared.Installs, expectedPath)
+		}
+	})
+}