fix: handle cross-device plugin moves

Close #628

Author: aooohan

internal/manager.go

@@ -78,12 +78,12 @@ func (m *Manager) LookupSdk(name string) (sdk.Sdk, error) {
 
 	// Normalize the name for cache lookup
 	normalizedName := strings.ToLower(name)
-	
+
 	// Check cache with read lock
 	m.mu.RLock()
 	s, ok := m.openSdks[normalizedName]
 	m.mu.RUnlock()
-	
+
 	if ok {
 		logger.Debugf("SDK %s found in cache\n", name)
 		return s, nil
@@ -109,7 +109,7 @@ func (m *Manager) LookupSdk(name string) (sdk.Sdk, error) {
 	m.mu.Lock()
 	m.openSdks[normalizedName] = s
 	m.mu.Unlock()
-	
+
 	logger.Debugf("SDK %s loaded and cached successfully\n", name)
 	return s, nil
 }
@@ -204,12 +204,12 @@ func (m *Manager) LoadAllSdk() ([]sdk.Sdk, error) {
 			s, err := sdk.NewSdk(m.RuntimeEnvContext, path)
 			if err == nil {
 				sdkSlice = append(sdkSlice, s)
-				
+
 				// Add to cache with write lock
 				m.mu.Lock()
 				m.openSdks[normalizedName] = s
 				m.mu.Unlock()
-				
+
 				logger.Debugf("SDK %s loaded successfully\n", sdkName)
 			} else {
 				logger.Debugf("Failed to load SDK %s: %v\n", sdkName, err)
@@ -233,7 +233,7 @@ func (m *Manager) Close() {
 	// while we're closing SDK handlers
 	m.mu.Lock()
 	defer m.mu.Unlock()
-	
+
 	for _, handler := range m.openSdks {
 		handler.Close()
 	}
@@ -357,7 +357,7 @@ func (m *Manager) Update(pluginName string) error {
 		}
 	}()
 	logger.Debugf("Moving updated plugin from %s to %s\n", tempPlugin.InstalledPath, sdkMetadata.PluginInstalledPath)
-	if err = os.Rename(tempPlugin.InstalledPath, sdkMetadata.PluginInstalledPath); err != nil {
+	if err = util.MovePath(tempPlugin.InstalledPath, sdkMetadata.PluginInstalledPath); err != nil {
 		return fmt.Errorf("update %s plugin failed, err: %w", pluginName, err)
 	}
 
@@ -539,7 +539,7 @@ func (m *Manager) Add(pluginName, url, alias string) error {
 		}
 	}
 	logger.Debugf("Moving plugin from %s to %s\n", tempPlugin.InstalledPath, installPath)
-	if err = os.Rename(tempPlugin.InstalledPath, installPath); err != nil {
+	if err = util.MovePath(tempPlugin.InstalledPath, installPath); err != nil {
 		logger.Debugf("Failed to move plugin: %v\n", err)
 		return fmt.Errorf("install plugin error: %w", err)
 	}

internal/shared/util/file.go

@@ -17,14 +17,18 @@
 package util
 
 import (
+	"errors"
 	"io"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"runtime"
 	"strings"
+	"syscall"
 )
 
+var renamePath = os.Rename
+
 func FileExists(filename string) bool {
 	_, err := os.Stat(filename)
 	if os.IsNotExist(err) {
@@ -57,6 +61,33 @@ func CopyFile(src, dst string) error {
 	return nil
 }
 
+// MovePath moves a file or directory to the target path.
+// If a cross-device rename fails, it falls back to copy and remove.
+func MovePath(src, dst string) error {
+	if err := renamePath(src, dst); err == nil {
+		return nil
+	} else if !isCrossDeviceRenameError(err) {
+		return err
+	}
+
+	info, err := os.Stat(src)
+	if err != nil {
+		return err
+	}
+
+	if info.IsDir() {
+		if err := copyDir(src, dst); err != nil {
+			return err
+		}
+	} else {
+		if err := copySingleFile(src, dst, info.Mode()); err != nil {
+			return err
+		}
+	}
+
+	return os.RemoveAll(src)
+}
+
 // MoveFiles Move a folder or file to a specified directory
 func MoveFiles(src, targetDir string) error {
 	info, err := os.Stat(src)
@@ -127,3 +158,66 @@ func MkSymlink(oldname, newname string) (err error) {
 	}
 	return os.Symlink(oldname, newname)
 }
+
+func isCrossDeviceRenameError(err error) bool {
+	var linkErr *os.LinkError
+	if errors.As(err, &linkErr) {
+		err = linkErr.Err
+	}
+
+	if errors.Is(err, syscall.EXDEV) {
+		return true
+	}
+
+	msg := strings.ToLower(err.Error())
+	return strings.Contains(msg, "cross-device link") ||
+		strings.Contains(msg, "different disk drive") ||
+		strings.Contains(msg, "not same device")
+}
+
+func copyDir(src, dst string) error {
+	info, err := os.Stat(src)
+	if err != nil {
+		return err
+	}
+	if err := os.MkdirAll(dst, info.Mode().Perm()); err != nil {
+		return err
+	}
+
+	entries, err := os.ReadDir(src)
+	if err != nil {
+		return err
+	}
+
+	for _, entry := range entries {
+		srcPath := filepath.Join(src, entry.Name())
+		dstPath := filepath.Join(dst, entry.Name())
+
+		if entry.IsDir() {
+			if err := copyDir(srcPath, dstPath); err != nil {
+				return err
+			}
+			continue
+		}
+
+		fileInfo, err := entry.Info()
+		if err != nil {
+			return err
+		}
+		if err := copySingleFile(srcPath, dstPath, fileInfo.Mode()); err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
+
+func copySingleFile(src, dst string, mode os.FileMode) error {
+	if err := os.MkdirAll(filepath.Dir(dst), 0755); err != nil {
+		return err
+	}
+	if err := CopyFile(src, dst); err != nil {
+		return err
+	}
+	return ChangeModeIfNot(dst, mode)
+}

internal/shared/util/file_test.go

@@ -0,0 +1,102 @@
+/*
+ *    Copyright 2026 Han Li and contributors
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+
+package util
+
+import (
+	"errors"
+	"os"
+	"path/filepath"
+	"syscall"
+	"testing"
+)
+
+func TestMovePathFallsBackOnCrossDeviceRename(t *testing.T) {
+	oldRenamePath := renamePath
+	renamePath = func(oldPath, newPath string) error {
+		return &os.LinkError{Op: "rename", Old: oldPath, New: newPath, Err: syscall.EXDEV}
+	}
+	t.Cleanup(func() {
+		renamePath = oldRenamePath
+	})
+
+	srcDir := filepath.Join(t.TempDir(), "src")
+	dstDir := filepath.Join(t.TempDir(), "dst")
+	nestedDir := filepath.Join(srcDir, "nested")
+
+	if err := os.MkdirAll(nestedDir, 0755); err != nil {
+		t.Fatalf("failed to create source directory: %v", err)
+	}
+	if err := os.WriteFile(filepath.Join(srcDir, "main.lua"), []byte("print('hello')\n"), 0644); err != nil {
+		t.Fatalf("failed to write root file: %v", err)
+	}
+	if err := os.WriteFile(filepath.Join(nestedDir, "config.txt"), []byte("ok"), 0600); err != nil {
+		t.Fatalf("failed to write nested file: %v", err)
+	}
+
+	if err := MovePath(srcDir, dstDir); err != nil {
+		t.Fatalf("MovePath returned error: %v", err)
+	}
+
+	if _, err := os.Stat(srcDir); !errors.Is(err, os.ErrNotExist) {
+		t.Fatalf("expected source to be removed, got err=%v", err)
+	}
+
+	content, err := os.ReadFile(filepath.Join(dstDir, "main.lua"))
+	if err != nil {
+		t.Fatalf("failed to read moved root file: %v", err)
+	}
+	if string(content) != "print('hello')\n" {
+		t.Fatalf("unexpected root file content: %q", content)
+	}
+
+	info, err := os.Stat(filepath.Join(dstDir, "nested", "config.txt"))
+	if err != nil {
+		t.Fatalf("failed to stat moved nested file: %v", err)
+	}
+	if info.Mode().Perm() != 0600 {
+		t.Fatalf("expected nested file mode 0600, got %o", info.Mode().Perm())
+	}
+}
+
+func TestMovePathReturnsNonCrossDeviceErrors(t *testing.T) {
+	oldRenamePath := renamePath
+	renamePath = func(oldPath, newPath string) error {
+		return &os.LinkError{Op: "rename", Old: oldPath, New: newPath, Err: os.ErrPermission}
+	}
+	t.Cleanup(func() {
+		renamePath = oldRenamePath
+	})
+
+	srcFile := filepath.Join(t.TempDir(), "plugin.lua")
+	dstFile := filepath.Join(t.TempDir(), "plugin-copy.lua")
+
+	if err := os.WriteFile(srcFile, []byte("print('hello')\n"), 0644); err != nil {
+		t.Fatalf("failed to write source file: %v", err)
+	}
+
+	err := MovePath(srcFile, dstFile)
+	if !errors.Is(err, os.ErrPermission) {
+		t.Fatalf("expected permission error, got %v", err)
+	}
+
+	if _, statErr := os.Stat(srcFile); statErr != nil {
+		t.Fatalf("expected source file to remain in place, got %v", statErr)
+	}
+	if _, statErr := os.Stat(dstFile); !errors.Is(statErr, os.ErrNotExist) {
+		t.Fatalf("expected destination file to be absent, got %v", statErr)
+	}
+}