Skip to content

Commit 39a9623

Browse files
authored
do not use as_str, as_bytes in tests (#563)
1 parent b7ef0a1 commit 39a9623

2 files changed

Lines changed: 6 additions & 23 deletions

File tree

vertica_python/tests/common/base.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import getpass
4444
from configparser import ConfigParser
4545

46-
from ...compat import as_str, as_bytes
4746
from ...vertica.log import VerticaLogging
4847

4948

@@ -128,22 +127,6 @@ def tearDown(self):
128127
self.logger.info('\n'+'-'*10+' End '+self.__class__.__name__+"."+self._testMethodName+' '+'-'*10+'\n')
129128

130129
# Common assertions
131-
def assertStrEqual(self, first, second, msg=None):
132-
first_str = as_str(first)
133-
second_str = as_str(second)
134-
self.assertEqual(first=first_str, second=second_str, msg=msg)
135-
136-
def assertBytesEqual(self, first, second, msg=None):
137-
first_bytes = as_bytes(first)
138-
second_bytes = as_bytes(second)
139-
self.assertEqual(first=first_bytes, second=second_bytes, msg=msg)
140-
141-
def assertResultEqual(self, value, result, msg=None):
142-
if isinstance(value, str):
143-
self.assertStrEqual(first=value, second=result, msg=msg)
144-
else:
145-
self.assertEqual(first=value, second=result, msg=msg)
146-
147130
def assertListOfListsEqual(self, list1, list2, msg=None):
148131
self.assertEqual(len(list1), len(list2), msg=msg)
149132
for l1, l2 in zip(list1, list2):

vertica_python/tests/integration_tests/test_unicode.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_unicode_query(self):
4848
cur.execute(query)
4949
res = cur.fetchone()
5050

51-
self.assertResultEqual(value, res[0])
51+
self.assertEqual(value, res[0])
5252

5353
def test_unicode_list_parameter(self):
5454
values = ['\u00f1', 'foo', 3]
@@ -60,7 +60,7 @@ def test_unicode_list_parameter(self):
6060
results = cur.fetchone()
6161

6262
for val, res in zip(values, results):
63-
self.assertResultEqual(val, res)
63+
self.assertEqual(val, res)
6464

6565
def test_unicode_named_parameter_binding(self):
6666
values = ['\u16b1', 'foo', 3]
@@ -74,7 +74,7 @@ def test_unicode_named_parameter_binding(self):
7474
results = cur.fetchone()
7575

7676
for val, res in zip(values, results):
77-
self.assertResultEqual(val, res)
77+
self.assertEqual(val, res)
7878

7979
def test_string_query(self):
8080
value = 'test'
@@ -97,7 +97,7 @@ def test_string_named_parameter_binding(self):
9797
cur.execute(query, {key: value})
9898
res = cur.fetchone()
9999

100-
self.assertResultEqual(value, res[0])
100+
self.assertEqual(value, res[0])
101101

102102
# unit test for issue #160
103103
def test_null_named_parameter_binding(self):
@@ -110,7 +110,7 @@ def test_null_named_parameter_binding(self):
110110
cur.execute(query, {key: value})
111111
res = cur.fetchone()
112112

113-
self.assertResultEqual(value, res[0])
113+
self.assertEqual(value, res[0])
114114

115115
# unit test for issue #160
116116
def test_null_list_parameter(self):
@@ -123,4 +123,4 @@ def test_null_list_parameter(self):
123123
results = cur.fetchone()
124124

125125
for val, res in zip(values, results):
126-
self.assertResultEqual(val, res)
126+
self.assertEqual(val, res)

0 commit comments

Comments
 (0)