Implement suggestions

Author: verkligheten

lib/viberroo/bot.rb

@@ -140,10 +140,12 @@ def remove_webhook
     # @see https://viber.github.io/docs/tools/keyboards/#buttons-parameters
     # @see https://developers.viber.com/docs/api/rest-bot-api/#keyboards
     #
-    def send_message(message:, keyboard: {})
+    def send_message(message, keyboard: {})
       request(
         URL::MESSAGE,
-        { receiver: @response.user_id }.merge(message, keyboard, min_api_version_hash(keyboard))
+        { receiver: @response.user_id }.merge(message, keyboard).tap do |hash|
+          hash.merge!(min_api_version_hash(keyboard)) unless hash[:min_api_version]
+        end
       )
     end
 

spec/bot_spec.rb

@@ -8,7 +8,7 @@
   let(:bot) { Viberroo::Bot.new(token: token, response: response) }
 
   describe '#send_message' do
-    subject { bot.send_message(message: message, keyboard: keyboard) }
+    subject { bot.send_message(message, keyboard: keyboard) }
 
     let(:message) do
       {
@@ -45,6 +45,21 @@
       end
     end
 
+    context 'when keyboard contain single input with api version but min_api-version was set before' do
+      let(:min_api_version) { 7 }
+      let(:message)         { { min_api_version: min_api_version } }
+      let(:button)          { Viberroo::Input.share_phone_button({}) }
+      let(:keyboard)        { Viberroo::Input.keyboard(Buttons: [button]) }
+
+      it 'sets correct :min_api_version attr in the params root' do
+        expect(bot).to receive(:request).with(
+          Viberroo::URL::MESSAGE,
+          { receiver: response.user_id }.merge(message, keyboard, min_api_version: min_api_version)
+        )
+        subject
+      end
+    end
+
     context 'when keyboard contain multiple inputs one of which has no api versions' do
       let(:button_one)      { Viberroo::Input.share_phone_button({}) }
       let(:button_two)      { Viberroo::Input.reply_button({}) }