Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Commit 1747089

Browse files
committed
virt-install: Enable all devices for non-HVM
While things like sound devs and watchdogs are HVM only, encoding this info into virt-install is kind of useless: having these devices in the XML is misleading, but not harmful. This will save bug reports like 'hey why doesn't --soundhw work for PV'
1 parent 3e7c849 commit 1747089

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

virt-install

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -790,12 +790,11 @@ def main():
790790
cli.get_uuid(options.uuid, guest)
791791
cli.get_vcpus(options.vcpus, options.check_cpu, guest, conn)
792792
cli.get_cpuset(options.cpuset, guest.memory, guest, conn)
793-
if ishvm:
794-
get_watchdog(options.watchdog, guest)
795-
cli.get_sound(options.sound, options.soundhw, guest)
796-
get_chardevs(VirtualDevice.VIRTUAL_DEV_SERIAL, options.serials, guest)
797-
get_chardevs(VirtualDevice.VIRTUAL_DEV_PARALLEL, options.parallels,
798-
guest)
793+
794+
get_watchdog(options.watchdog, guest)
795+
cli.get_sound(options.sound, options.soundhw, guest)
796+
get_chardevs(VirtualDevice.VIRTUAL_DEV_SERIAL, options.serials, guest)
797+
get_chardevs(VirtualDevice.VIRTUAL_DEV_PARALLEL, options.parallels, guest)
799798

800799
guest.autostart = options.autostart
801800
guest.description = options.description

0 commit comments

Comments
 (0)