Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Commit 1d76b58

Browse files
committed
Add child_dev option to NodeDevice pretty_description.
1 parent e678d9b commit 1d76b58

1 file changed

Lines changed: 24 additions & 10 deletions

File tree

virtinst/NodeDeviceParser.py

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,14 @@ def __init__(self, node):
4040

4141
self._parseNodeXML(node)
4242

43-
def pretty_name(self):
43+
def pretty_name(self, child_dev=None):
4444
"""
4545
Use device information to attempt to print a human readable device
4646
name.
4747
48+
@param child_dev: Child node device to display in description
49+
@type child_dev: L{NodeDevice}
50+
4851
@returns Device description string
4952
@rtype C{str}
5053
"""
@@ -110,7 +113,8 @@ def parseXML(self, node):
110113
self._parseHelper(child, firmware_map)
111114
child = child.next
112115

113-
def pretty_name(self):
116+
def pretty_name(self, child_dev=None):
117+
ignore = child_dev
114118
desc = _("System")
115119
if self.hw_vendor:
116120
desc += ": %s" % self.hw_vendor
@@ -140,7 +144,8 @@ def parseXML(self, node):
140144
self._parseValueHelper(child, value_map)
141145
child = child.next
142146

143-
def pretty_name(self):
147+
def pretty_name(self, child_dev=None):
148+
ignore = child_dev
144149
desc = self.name
145150
if self.interface:
146151
desc = _("Interface %s") % self.interface
@@ -183,11 +188,15 @@ def parseXML(self, node):
183188

184189
child = child.next
185190

186-
def pretty_name(self):
191+
def pretty_name(self, child_dev=None):
187192
devstr = "%.2X:%.2X:%X" % (int(self.bus),
188193
int(self.slot),
189194
int(self.function))
190-
desc = "%s %s" % (devstr, str(self.product_name))
195+
if child_dev:
196+
desc = "%s %s (%s)" % (devstr, child_dev.pretty_name(),
197+
str(self.product_name))
198+
else:
199+
desc = "%s %s" % (devstr, str(self.product_name))
191200
return desc
192201

193202
class USBDevice(NodeDevice):
@@ -221,7 +230,8 @@ def parseXML(self, node):
221230

222231
child = child.next
223232

224-
def pretty_name(self):
233+
def pretty_name(self, child_dev=None):
234+
ignore = child_dev
225235
devstr = "%.3d:%.3d" % (int(self.bus), int(self.device))
226236
desc = "%s %s %s" % (devstr, str(self.vendor_name),
227237
str(self.product_name))
@@ -277,7 +287,8 @@ def parseXML(self, node):
277287

278288
child = child.next
279289

280-
def pretty_name(self):
290+
def pretty_name(self, child_dev=None):
291+
ignore = child_dev
281292
desc = ""
282293
if self.drive_type:
283294
desc = self.drive_type
@@ -308,7 +319,8 @@ def parseXML(self, node):
308319
"protocol" : "protocol" }
309320
self._parseHelper(node, val_map)
310321

311-
def pretty_name(self):
322+
def pretty_name(self, child_dev=None):
323+
ignore = child_dev
312324
return self.name
313325

314326
class SCSIDevice(NodeDevice):
@@ -331,7 +343,8 @@ def parseXML(self, node):
331343
"type" : "type"}
332344
self._parseHelper(node, val_map)
333345

334-
def pretty_name(self):
346+
def pretty_name(self, child_dev=None):
347+
ignore = child_dev
335348
return self.name
336349

337350
class SCSIBus(NodeDevice):
@@ -346,7 +359,8 @@ def parseXML(self, node):
346359
val_map = { "host" : "host" }
347360
self._parseHelper(node, val_map)
348361

349-
def pretty_name(self):
362+
def pretty_name(self, child_dev=None):
363+
ignore = child_dev
350364
return self.name
351365

352366
def is_nodedev_capable(conn):

0 commit comments

Comments
 (0)