Use logging exc_info=True

Rather than rolling our own

Author: crobinso

virt-install

@@ -88,7 +88,7 @@ def supports_pxe(guest):
             if forward and forward != "nat":
                 return True
         except:
-            _util.log_exception("Error checking if PXE supported")
+            logging.debug("Error checking if PXE supported", exc_info=True)
             return True
 
     return False
@@ -654,7 +654,7 @@ def start_install(guest, continue_inst, options):
             guest.connect_console(conscb)
 
     except KeyboardInterrupt, e:
-        cli.log_exception()
+        logging.debug("", exc_info=True)
         guest.terminate_console()
         print_stderr(_("Domain install interrupted."))
     except RuntimeError, e:
@@ -1009,7 +1009,7 @@ if __name__ == "__main__":
     except SystemExit, sys_e:
         sys.exit(sys_e.code)
     except KeyboardInterrupt:
-        cli.log_exception()
+        logging.debug("", exc_info=True)
         print_stderr(_("Installation aborted at user request"))
     except Exception, main_e:
         fail(main_e)

virtinst/CloneManager.py

@@ -611,7 +611,7 @@ def _get_original_devices_info(self, xml):
                                 validate=validate)
                 d.target = target
             except Exception, e:
-                _util.log_exception(e)
+                logging.debug("", exc_info=True)
                 raise ValueError(_("Could not determine original disk "
                                    "information: %s" % str(e)))
             disks.append(d)

virtinst/DistroInstaller.py

@@ -232,7 +232,8 @@ def set_location(self, val):
                                 volName=stuple)
                 val = d.path
             except:
-                _util.log_exception("Error validating install location")
+                logging.debug("Error validating install location",
+                              exc_info=True)
                 raise ValueError(_("Checking installer location failed: "
                                    "Could not find media '%s'." % str(val)))
         elif not validated:

virtinst/_util.py

@@ -28,7 +28,6 @@
 import re
 import commands
 import logging
-import traceback
 import platform
 import subprocess
 
@@ -215,23 +214,6 @@ def fetch_all_guests(conn):
 
     return (active, inactive)
 
-def log_exception(msg=""):
-    """
-    Log the most recent backtrace at the DEBUG level, rather than the
-    ERROR level (which goes to stderr when used with the cli tools)
-
-    @param msg: Option message to log before the backtrace
-    """
-    msg = str(msg)
-    tb = "".join(traceback.format_exc()).strip()
-    if tb != "None":
-        if msg:
-            msg += "\n"
-        msg += tb
-
-    if msg:
-        logging.debug(msg)
-
 def set_xml_path(xml, path, newval):
     """
     Set the passed xml xpath to the new value

virtinst/cli.py

@@ -35,7 +35,6 @@
 
 import virtinst
 from virtinst import _util
-from _util import log_exception
 from _util import listify
 from virtinst import _gettext as _
 
@@ -346,7 +345,7 @@ def do_creds(creds, cbdata):
     try:
         return _do_creds(creds, cbdata)
     except:
-        log_exception("Error in creds callback.")
+        logging.debug("Error in creds callback.", exc_info=True)
         raise
 
 def _do_creds(creds, cbdata_ignore):
@@ -438,7 +437,7 @@ def fail(msg, do_exit=True):
     Convenience function when failing in cli app
     """
     logging.error(msg)
-    log_exception()
+    logging.debug("", exc_info=True)
     if do_exit:
         _fail_exit()