virt-clone: Add --clone-running option

Skips shutoff/paused check to allow cloning running VMs. Useful for testing.

Author: crobinso

tests/clitest.py

@@ -576,11 +576,15 @@
         "--original-xml %(CLONE_DISK_XML)s --auto-clone",
         # Auto flag w/ managed storage,
         "--original-xml %(CLONE_STORAGE_XML)s --auto-clone",
+        # Auto flag, actual VM, skip state check
+        "-o test-for-clone --auto-clone --clone-running",
       ],
 
       "invalid" : [
         # Just the auto flag
         "--auto-clone"
+        # Auto flag, actual VM, without state skip
+        "-o test-for-clone --auto-clone",
       ]
     }, # category "misc"
 

virt-clone

@@ -190,6 +190,9 @@ def parse_args():
                     help=_("Do not prompt for input. Answers yes where "
                            "applicable, terminates for all other prompts"),
                     default=False)
+    misc.add_option("", "--clone-running", action="store_true",
+                    dest="clone_running", default=False,
+                    help=_("Allow cloning a running domain"))
     parser.add_option_group(misc)
 
     (options, dummy) = parser.parse_args()
@@ -211,6 +214,7 @@ def main():
     design = clmgr.CloneDesign(connection=conn)
 
     try:
+        design.clone_running = options.clone_running
         get_original_guest(options.original_guest, options.original_xml,
                            design)
         get_clone_name(options.new_name, options.auto_clone, design)

virtinst/CloneManager.py

@@ -128,6 +128,7 @@ def __init__(self, connection):
         self._force_target       = []
         self._skip_target        = []
         self._preserve           = True
+        self._clone_running      = False
 
         # Default clone policy for back compat: don't clone readonly,
         # shareable, or empty disks
@@ -368,6 +369,15 @@ def get_clone_policy(self):
                             doc="List of policy rules for determining which "
                                 "vm disks to clone. See CLONE_POLICY_*")
 
+    def get_clone_running(self):
+        return self._clone_running
+    def set_clone_running(self, val):
+        self._clone_running = bool(val)
+    clone_running = property(get_clone_running, set_clone_running,
+                             doc="Allow cloning a running VM. If enabled, "
+                                 "domain state is not checked before "
+                                 "cloning.")
+
     # Functional methods
 
     def setup_original(self):
@@ -390,7 +400,8 @@ def setup_original(self):
         logging.debug("Original sizes: %s" % (self.original_devices_size))
 
         # If domain has devices to clone, it must be 'off' or 'paused'
-        if self._original_dom and len(self.original_devices) != 0:
+        if (not self.clone_running and
+            (self._original_dom and len(self.original_devices) != 0)):
             status = self._original_dom.info()[0]
 
             if status not in [libvirt.VIR_DOMAIN_SHUTOFF,