VirtualDisk: Qemu can actually support more than 2 IDE cdroms

Author: crobinso

tests/clitest.py

@@ -163,7 +163,9 @@
         # Not specifying path= but creating storage
         "--disk %(NEWIMG1)s,format=raw,size=.0000001",
         # Colliding storage with --force
-        "--disk %(COLLIDE)s --force"
+        "--disk %(COLLIDE)s --force",
+        # Two IDE cds
+        "--disk path=%(EXISTIMG1)s,device=cdrom --disk path=%(EXISTIMG1)s,device=cdrom",
       ],
 
       "invalid": [
@@ -175,8 +177,6 @@
         "--file %(NEWIMG1)s",
         # Too many IDE
         "--file %(EXISTIMG1)s --file %(EXISTIMG1)s --file %(EXISTIMG1)s --file %(EXISTIMG1)s --file %(EXISTIMG1)s",
-        # Two IDE cds
-        "--disk path=%(EXISTIMG1)s,device=cdrom --disk path=%(EXISTIMG1)s,device=cdrom",
         # Size, no file
         "--file-size .0001",
         # Specify a nonexistent pool

virtinst/VirtualDisk.py

@@ -1360,12 +1360,11 @@ def generate_target(self, skip_targets):
         if prefix is None:
             raise ValueError(_("Cannot determine device bus/type."))
 
-        # Special case: IDE cdrom must be hdc
+        # Special case: IDE cdrom should prefer hdc for back compat
         if self.device == self.DEVICE_CDROM and prefix == "hd":
             if "hdc" not in skip_targets:
                 self.target = "hdc"
                 return self.target
-            raise ValueError(_("IDE CDROM must use 'hdc', but target in use."))
 
         # Regular scanning
         for i in range(maxnode):