Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Commit 72da324

Browse files
committed
Add clearer docs to pylint script about actual bugs.
1 parent f263d55 commit 72da324

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

tests/pylint-virtinst.sh

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,8 @@ VD_MISMATCHED_ARGS="VirtualDisk.get_xml_config.*Arguments number differs"
3636
# urltest needs access to protected members for testing purposes
3737
URLTEST_ACCESS="TestURLFetch.*Access to a protected member"
3838

39-
# Libvirt connect() method is broken for getting an objects connection, this
40-
# workaround is required for now
41-
ACCESS__CONN="Access to a protected member _conn"
42-
43-
# FIXME: These are all bugs
44-
# There isn't a clean API way to access this functions from the API, but
45-
# they provide info that is needed. These need need to be fixed.
46-
PROT_MEM_BUGS="protected member (_lookup_osdict_key|_OS_TYPES|_prepare_install|_create_devices|_install_disks)"
39+
# We use some hacks in the test driver to simulate remote libvirt URIs
40+
TEST_HACKS="TestClone.*protected member _util"
4741

4842
# Scattered examples of legitimately unused arguments
4943
UNUSED_ARGS="(SuseDistro|SolarisDistro).isValidStore.*Unused argument 'progresscb'|.*Installer.prepare.*Unused argument|post_install_check.*Unused argument 'guest'|Guest.__init__.*Unused argument 'type'"
@@ -52,8 +46,16 @@ UNUSED_ARGS="(SuseDistro|SolarisDistro).isValidStore.*Unused argument 'progressc
5246
# tests.storage also invokes false positives using hasattr
5347
OUTSIDE_INIT="(.*Test.*|.*createPool.*)outside __init__"
5448

55-
# We use some hacks in the test driver to simulate remote libvirt URIs
56-
TEST_HACKS="TestClone.*protected member _util"
49+
50+
# FIXME: Everything skipped below are all bugs
51+
52+
# Libvirt connect() method is broken for getting an objects connection, this
53+
# workaround is required for now
54+
ACCESS__CONN="Access to a protected member _conn"
55+
56+
# There isn't a clean API way to access this functions from the API, but
57+
# they provide info that is needed. These need need to be fixed.
58+
PROT_MEM_BUGS="protected member (_lookup_osdict_key|_OS_TYPES|_prepare_install|_create_devices|_install_disks)"
5759

5860
DMSG=""
5961
addmsg() {

0 commit comments

Comments
 (0)