Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Commit 8ef0126

Browse files
committed
virt-install: Fix cpuset=auto
Some refactoring broke it a while back :(
1 parent 41c4bc1 commit 8ef0126

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

virt-image

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def main(conn=None):
164164
cli.get_memory(options.memory, guest, image.domain.memory)
165165
cli.get_uuid(options.uuid, guest)
166166
cli.get_vcpus(guest, options.vcpus, options.check_cpu, image.domain.vcpu)
167-
cli.get_cpuset(guest, options.cpuset)
167+
cli.get_cpuset(guest, options.cpuset, guest.memory)
168168
cli.parse_cpu(guest, options.cpu)
169169
get_networks(image.domain, guest, options)
170170

virt-install

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,6 @@ def build_guest_instance(conn, options):
478478
# Guest configuration
479479
cli.get_uuid(options.uuid, guest)
480480
cli.get_vcpus(guest, options.vcpus, options.check_cpu)
481-
cli.get_cpuset(guest, options.cpuset)
482481
cli.parse_numatune(guest, options.numatune)
483482
cli.parse_cpu(guest, options.cpu)
484483
cli.parse_security(guest, options.security)
@@ -534,6 +533,9 @@ def build_guest_instance(conn, options):
534533
# this after setting guest.installer at least
535534
check_option_collisions(options, guest)
536535

536+
# Needs to come after setting memory
537+
cli.get_cpuset(guest, options.cpuset, guest.memory)
538+
537539
# Warnings
538540
if options.pxe and not supports_pxe(guest):
539541
logging.warn(_("The guest's network configuration does not support "

virtinst/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -822,15 +822,15 @@ def get_vcpus(guest, vcpus, check_cpu, image_vcpus=None):
822822
if not prompt_for_yes_or_no(msg, askmsg):
823823
nice_exit()
824824

825-
def get_cpuset(guest, cpuset):
825+
def get_cpuset(guest, cpuset, memory):
826826
conn = guest.conn
827827
if cpuset and cpuset != "auto":
828828
guest.cpuset = cpuset
829829

830830
elif cpuset == "auto":
831831
tmpset = None
832832
try:
833-
tmpset = Guest.generate_cpuset(conn, guest.memory)
833+
tmpset = Guest.generate_cpuset(conn, memory)
834834
except Exception, e:
835835
logging.debug("Not setting cpuset: %s", str(e))
836836

0 commit comments

Comments
 (0)