virt-install: Fix setting default host for --serial tcp,host=:PORT

Author: crobinso

tests/cli-test-xml/compare/many-devices.xml

@@ -33,7 +33,10 @@
       <mac address='00:11:22:33:44:55'/>
     </interface>
     <input type='mouse' bus='ps2'/>
-    <console type='pty'/>
+    <serial type='tcp'>
+      <source mode='bind' host='127.0.0.1' service='2222'/>
+      <protocol type='telnet'/>
+    </serial>
   </devices>
 </domain>
 <domain type='test'>
@@ -70,6 +73,9 @@
       <mac address='00:11:22:33:44:55'/>
     </interface>
     <input type='mouse' bus='ps2'/>
-    <console type='pty'/>
+    <serial type='tcp'>
+      <source mode='bind' host='127.0.0.1' service='2222'/>
+      <protocol type='telnet'/>
+    </serial>
   </devices>
 </domain>

tests/clitest.py

@@ -505,7 +505,8 @@
         # Lot's of devices
         ("--hvm --pxe "
          "--disk %(EXISTIMG1)s,cache=writeback,io=threads,perms=sh "
-         "--disk %(NEWIMG1)s,sparse=false,size=.001,perms=ro",
+         "--disk %(NEWIMG1)s,sparse=false,size=.001,perms=ro "
+         "--serial tcp,host=:2222,mode=bind,protocol=telnet ",
          "many-devices"),
       ],
 

virt-install

@@ -198,7 +198,7 @@ def parse_char_option(guest, dev_type, optstring):
         if key in opts:
             del(opts[key])
 
-        return host, port
+        return host or None, port or None
 
     host, port = parse_host("host")
     bind_host, bind_port = parse_host("bind_host")