Added custom fact. Removed $domainNetbiosName class parameter. Used custom fact instead.

Author: matt6697

CHANGELOG.md

@@ -4,6 +4,7 @@
 - **BREAKING CHANGE** : Require puppetlabs/dsc compiled with SQLServerDSC = 10.0.0.0
 - **BREAKING CHANGE** : Changed $sqlservicecredential_username and  $sqlagentservicecredential_username format. User accounts now required **WITHOUT** Netbios Domain Name prefix.
 - **BREAKING CHANGE** : Removed $domainName class parameter. Used facts instead.
+- **BREAKING CHANGE** : Removed $domainNetbiosName class parameter. Used custom fact instead.
 
 ## Version 1.1.0
 - Initial release

README.markdown

@@ -22,9 +22,9 @@ The module can be installed on a Standard, Datacenter, or Core version of Window
 - **setupdir** : (string) Path of a folder containing the SQL Server installer (unarchive the ISO image in this folder).
 - **sa_password** : (string) SQL Server SA password for mixed mode SQL authentication configuration.
 - **productkey** : (string)(optionnal) Product key for licensed installations.
-- **sqlservicecredential_username** : (String) Service account for the SQL service **WITHOUT** Netbios Domain Name prefix
+- **sqlservicecredential_username** : (String) Domain service account for the SQL service **WITHOUT** Netbios Domain Name prefix. The account will be automatically created in Active Directory by the module. MSSQLSvc/fqdn_of_sql_server_node SPN will be associated with the service account.
 - **sqlservicecredential_password** : (String) :  Password of the service account for the SQL service. Should be encrypted with hiera-eyaml.
-- **sqlagentservicecredential_username** : (String) Service account for the SQL Agent service **WITHOUT** Netbios Domain Name prefix
+- **sqlagentservicecredential_username** : (String) Domain service account for the SQL Agent service **WITHOUT** Netbios Domain Name prefix. The account will be automatically created in Active Directory by the module.
 - **sqlagentservicecredential_password** : (String) Password of the service account for the SQL Agent service. Should be encrypted with hiera-eyaml.
 - **sqladministratoraccounts** : (String[] Array) : Array of accounts to be made SQL administrators.
 - **sqluserdbdir** : (String)(optionnal) Path for SQL database files. Default to 'C:\Program Files\Microsoft SQL Server\MSSQL13.MSSQLSERVER\MSSQL\Data'
@@ -37,7 +37,6 @@ The module can be installed on a Standard, Datacenter, or Core version of Window
 - **fileShareWitness** : (String) Fileshare witness UNC path in the format'\\witness.company.local\witness$'. Needs to be writable by SQL nodes.
 - **listenerIP** : (String) The IP address used for the availability group listener, in the format 192.168.10.45/255.255.252.0.
 - **role** : (String) Needs to be 'primary' for primary SQL nodes or 'secondary' for SQL replica nodes
-- **domainNetbiosName** : (String) Active Directory domain NETBIOS name
 
 
 ## Installing a Microsoft SQL Server AlwaysOn cluster
@@ -72,8 +71,7 @@ node 'SQL01' {
 	  clusterIP => '192.168.1.60',
 	  fileShareWitness=> '\\192.168.1.10\quorum',
 	  listenerIP => '192.168.1.61/255.255.255.0',
-	  role => 'primary',
-	  domainNetbiosName => 'DOMAIN-TEST'
+	  role => 'primary'
 	}
 }
 
@@ -94,8 +92,7 @@ node 'SQL02' {
 	  clusterIP => '192.168.1.60',
 	  fileShareWitness=> '\\192.168.1.10\quorum',
 	  listenerIP => '192.168.1.61/255.255.255.0',
-	  role => 'secondary',
-	  domainNetbiosName => 'DOMAIN-TEST'
+	  role => 'secondary'
 	}
 }
 

lib/facter/domainnetbiosname.rb

@@ -0,0 +1,14 @@
+#https://puppet.com/blog/starting-out-writing-custom-facts-windows
+Facter.add('domainnetbiosname') do
+  confine :osfamily => :windows
+  setcode do
+    begin
+      require 'win32ole'
+      wmi = WIN32OLE.connect("winmgmts:\\\\.\\root\\cimv2")
+      win32ntdomain = wmi.ExecQuery("SELECT * FROM Win32_NTDomain").each.first
+      win32ntdomain.DomainName
+    rescue
+      nil
+    end
+  end
+end

manifests/alwaysonconfig.pp

@@ -43,7 +43,7 @@
 		dsc_servername => $hostname,
 		dsc_instancename => 'MSSQLSERVER',
 		dsc_name => 'HADR',
-		dsc_principal => "${domainNetbiosName}\\$sqlservicecredential_username",
+		dsc_principal => "${domainnetbiosname}\\$sqlservicecredential_username",
 		dsc_permission => 'CONNECT',
 		dsc_psdscrunascredential => {'user' => $setup_svc_username, 'password' => $setup_svc_password}
   }

manifests/config.pp

@@ -28,15 +28,15 @@
 		dsc_ensure => 'Present',
 		dsc_servername => $hostname,
 		dsc_instancename => 'MSSQLSERVER',
-		dsc_name => "${domainNetbiosName}\\Domain Admins",
+		dsc_name => "${domainnetbiosname}\\Domain Admins",
 		dsc_logintype => 'WindowsGroup',
 		dsc_psdscrunascredential => {'user' => $setup_svc_username, 'password' => $setup_svc_password}
 	}
 
 	dsc_sqlserverrole{'AddDomainAdminsSQLSysadmin':
 		dsc_ensure => 'Present',
 		dsc_serverrolename => 'sysadmin',
-		dsc_memberstoinclude => "${domainNetbiosName}\\Domain Admins",
+		dsc_memberstoinclude => "${domainnetbiosname}\\Domain Admins",
 		dsc_servername => $hostname,
 		dsc_instancename => 'MSSQLSERVER',
 		require => Dsc_sqlserverlogin['DomainAdminsLogin'],
@@ -48,7 +48,7 @@
 		dsc_ensure => 'Present',
 		dsc_servername => $hostname,
 		dsc_instancename => 'MSSQLSERVER',
-		dsc_name => "${domainNetbiosName}\\$sqlservicecredential_username",
+		dsc_name => "${domainnetbiosname}\\$sqlservicecredential_username",
 		dsc_logintype => 'WindowsUser',
 		dsc_psdscrunascredential => {'user' => $setup_svc_username, 'password' => $setup_svc_password}
 	}

manifests/domainconfig.pp

@@ -31,7 +31,6 @@
   $fileShareWitness, #Format '\\witness.company.local\witness$'
   $listenerIP, #The IP address used for the availability group listener, in the format 192.168.10.45/255.255.252.0.
   $role, ##primary or secondary
-  $domainNetbiosName
   )
 {
   #Using $domain fact du get the active directory domain name

manifests/init.pp

@@ -53,9 +53,9 @@
       dsc_securitymode => 'SQL',
       dsc_sapwd => {'user' => 'sa', 'password' => $sa_password},
       dsc_productkey => $productkey,
-      dsc_sqlsvcaccount => {'user' => "${domainNetbiosName}\\$sqlservicecredential_username", 'password' => $sqlservicecredential_password},
-      dsc_agtsvcaccount => {'user' => "${domainNetbiosName}\\$sqlagentservicecredential_username", 'password' => $sqlagentservicecredential_password},
-      dsc_assvcaccount => {'user' => "${domainNetbiosName}\\$sqlservicecredential_username", 'password' => $sqlservicecredential_password},
+      dsc_sqlsvcaccount => {'user' => "${domainnetbiosname}\\$sqlservicecredential_username", 'password' => $sqlservicecredential_password},
+      dsc_agtsvcaccount => {'user' => "${domainnetbiosname}\\$sqlagentservicecredential_username", 'password' => $sqlagentservicecredential_password},
+      dsc_assvcaccount => {'user' => "${domainnetbiosname}\\$sqlservicecredential_username", 'password' => $sqlservicecredential_password},
       dsc_sqlsysadminaccounts => $sqladministratoraccounts,
       dsc_assysadminaccounts  => $sqladministratoraccounts,
       dsc_installshareddir => 'C:\Program Files\Microsoft SQL Server',

manifests/install.pp

@@ -1,4 +1,5 @@
 class sqlserveralwayson::serviceaccounts inherits sqlserveralwayson {
+
 	#Needed for ActiveDirectory remote management using Powershell
 	dsc_windowsfeature{ 'RSAT-AD-Powershell':
 		dsc_ensure => 'Present',