Migrated puppet code to future parser syntax (4.x) v2

Author: matt6697

README.markdown

@@ -15,6 +15,8 @@ The SSL certificate provided needs to be a password protected p12/pfx certificat
 
 The module can be installed on a Standard, Datacenter version of Windows 2012R2 or Windows 2016. **Core version is not supported by Citrix for delivery Controller installation**.
 
+Migrated puppet example code in README.md to future parser syntax (4.x). Impact on parameters refering to remote locations (file shares) which have to be prefixed with \\\\ instead of the classical \\. This is because of Puppet >= 4.x parsing \\ as a single \ in single-quoted strings. Use parser = future in puppet 3.x /etc/puppet/puppet.conf to use this new configuration in your Puppet 3.x and prepare Puppet 4.x migration.
+
 ## Usage
 - **svc_username** : (string) Privileged account used by Puppet for installing the software and the Xendesktop Site (cred_ssp server and client, SQL server write access, local administrator privilèges needed)
 - **svc_password** : (string) Password of the privileged account. Should be encrypted with hiera-eyaml.
@@ -24,13 +26,13 @@ The module can be installed on a Standard, Datacenter version of Windows 2012R2
 - **sitedatabasename** : (string) Name of the citrix site database to be created
 - **loggingdatabasename** : (string) Name of the citrix logging database to be created
 - **monitordatabasename** : (string) Name of the citrix monitor database to be created
-- **sourcepath** : (string) Path of a folder containing the Xendesktop 7.x installer (unarchive the ISO image in this folder).
+- **sourcepath** : (string) Path of a folder containing the Xendesktop 7.x installer (unarchive the ISO image in this folder). Has to be prefixed with \\\\ instead of the classical \\ if using UNC Path and Puppet >= 4.x or Puppet 3.x future parser.
 - **xd7administrator** : (string) ActiveDirectory user or group which will be granted Citrix Administrator rights.
 - **sqlalwayson** : (boolean) : true or false. Activate database AlwaysOn availability group membership ? Default is false. Needs to be true for a production grade environment
 - **sqlavailabilitygroup** : (string) (optionnal if sqlalwayson = false) : Name of the SQL AlwaysOn availability group.
-- **sqldbbackuppath** :  (string) (optionnal if sqlalwayson = false) : UNC path of a writable network folder to backup/restore databases during AlwaysOn availability group membership configuration. needs to be writable from the sql server nodes.
+- **sqldbbackuppath** :  (string) (optionnal if sqlalwayson = false) : UNC path of a writable network folder to backup/restore databases during AlwaysOn availability group membership configuration. needs to be writable from the sql server nodes. Has to be prefixed with \\\\ instead of the classical \\ if using Puppet >= 4.x or Puppet 3.x future parser.
 - **https** : (boolean) : true or false. Deploy SSL certificate and activate SSL access to Citrix XML service ? Default : false
-- **sslCertificateSourcePath** : (string) Location of the SSL certificate (p12 / PFX format with private key). Can be local folder, UNC path, HTTP URL)
+- **sslCertificateSourcePath** : (string) Location of the SSL certificate (p12 / PFX format with private key). Can be local folder, UNC path, HTTP URL). Has to be prefixed with \\\\ instead of the classical \\ if using UNC Path and Puppet >= 4.x or Puppet 3.x future parser.
 - **sslCertificatePassword** : (string) Password protecting the p12/pfx SSL certificate file.
 - **sslCertificateThumbprint** : (string) Thumbprint of the SSL certificate (available in the SSL certificate).
 
@@ -47,13 +49,13 @@ node 'CXDC' {
 	  sitedatabasename => 'SITE_DB',
 	  loggingdatabasename => 'LOG_DB',
 	  monitordatabasename => 'MONITOR_DB',
-	  sourcepath => '\\fileserver\xendesktop715',
+	  sourcepath => '\\\\fileserver\xendesktop715',
 	  xd7administrator => 'TESTLAB\Domain Admins',
 	  sqlalwayson => true,
 	  sqlavailabilitygroup => 'CLSDB01',
-	  sqldbbackuppath => '\\fileserver\backup\sql',
+	  sqldbbackuppath => '\\\\fileserver\backup\sql',
 	  https => true,
-	  sslCertificateSourcePath => '\\fileserver\ssl\cxdc.pfx',
+	  sslCertificateSourcePath => '\\\\fileserver\ssl\cxdc.pfx',
 	  sslCertificatePassword => 'P@ssw0rd',
 	  sslCertificateThumbprint => '44cce73845feef4da4d369a37386c862eb3bd4e1'  
 	}

changelog.md

@@ -3,6 +3,7 @@
 ## Unreleased
 - **BREAKING CHANGE** : Require puppetlabs/dsc compiled with SQLServerDSC = 10.0.0.0
 - **BREAKING CHANGE** : Removed unneeded $domainNetbiosName parameter.
+- **BREAKING CHANGE** : Migrated puppet example code in README.md to future parser syntax (4.x). Impact on parameters refering to remote locations (file shares) which have to be prefixed with \\\\ instead of the classical \\. This is because of Puppet >= 4.x parsing \\ as a single \ in single-quoted strings. Use parser = future in puppet 3.x /etc/puppet/puppet.conf to use this new configuration in your Puppet 3.x and prepare Puppet 4.x migration.
 
 ## Version 1.1.0
 - Initial release

manifests/install.pp

@@ -26,7 +26,7 @@
   #Install Delivery Controller
 	dsc_xd7features { 'XD7DeliveryController':
 	 dsc_issingleinstance => 'Yes',
-	 dsc_role => [Studio, Controller],
+	 dsc_role => ['Studio', 'Controller'],
 	 dsc_sourcepath => $sourcepath,
 	 dsc_ensure => 'present',
 	 require => Dsc_windowsfeature['iis'],

manifests/sslconfig.pp

@@ -42,7 +42,7 @@
       ensure => present,
       type   => 'dword',
       data   => '443',
-      require => Dsc_xd7features ['XD7DeliveryController']
+      require => Dsc_xd7features['XD7DeliveryController']
     }
   }
 }