Skip to content

Commit 29217eb

Browse files
bhushan-ebibhushan-ebi
authored
chore: Deploy fix - base href updated for local and live
2 parents 50ff05f + c3a626d commit 29217eb

5 files changed

Lines changed: 4 additions & 183 deletions

File tree

‎.github/workflows/deploy.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- name: Install Dependencies
5353
run: npm install
5454
- name: Build
55-
run: npm run build
55+
run: npm run build:ghpages
5656
- name: Upload Build Artifacts
5757
uses: actions/upload-artifact@v4
5858
with:

‎package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve",
7-
"build": "ng build --configuration production",
7+
"build": "ng build",
8+
"build:ghpages": "ng build --configuration production --base-href /vf-angular/",
89
"build:dev": "ng build --configuration development",
910
"watch": "ng build --watch --configuration development",
1011
"test": "ng test",

‎src/app/components/footer/footer.component.scss‎

Lines changed: 0 additions & 135 deletions
Original file line numberDiff line numberDiff line change
@@ -1,135 +0,0 @@
1-
.footer {
2-
background: #2d2d2d;
3-
color: white;
4-
padding: 4rem 2rem 2rem;
5-
6-
.footer-content {
7-
max-width: 1200px;
8-
margin: 0 auto;
9-
display: grid;
10-
grid-template-columns: 1.5fr 2fr;
11-
gap: 4rem;
12-
margin-bottom: 3rem;
13-
14-
.footer-brand {
15-
.logo {
16-
display: flex;
17-
align-items: center;
18-
gap: 0.5rem;
19-
margin-bottom: 1rem;
20-
21-
img {
22-
height: 32px;
23-
}
24-
25-
span {
26-
font-size: 1.25rem;
27-
font-weight: 500;
28-
}
29-
}
30-
31-
.description {
32-
color: #a0a0a0;
33-
line-height: 1.6;
34-
margin: 0;
35-
}
36-
}
37-
38-
.footer-links {
39-
display: grid;
40-
grid-template-columns: repeat(3, 1fr);
41-
gap: 2rem;
42-
43-
.link-group {
44-
h3 {
45-
color: white;
46-
font-size: 1rem;
47-
margin: 0 0 1rem;
48-
text-transform: uppercase;
49-
letter-spacing: 0.05em;
50-
}
51-
52-
ul {
53-
list-style: none;
54-
padding: 0;
55-
margin: 0;
56-
57-
li {
58-
margin-bottom: 0.5rem;
59-
60-
a {
61-
color: #a0a0a0;
62-
text-decoration: none;
63-
transition: color 0.2s;
64-
65-
&:hover {
66-
color: white;
67-
}
68-
}
69-
}
70-
}
71-
}
72-
}
73-
}
74-
75-
.footer-bottom {
76-
max-width: 1200px;
77-
margin: 0 auto;
78-
padding-top: 2rem;
79-
border-top: 1px solid rgba(255,255,255,0.1);
80-
display: flex;
81-
justify-content: space-between;
82-
align-items: center;
83-
84-
p {
85-
color: #a0a0a0;
86-
margin: 0;
87-
}
88-
89-
.legal-links {
90-
display: flex;
91-
gap: 1.5rem;
92-
93-
a {
94-
color: #a0a0a0;
95-
text-decoration: none;
96-
transition: color 0.2s;
97-
98-
&:hover {
99-
color: white;
100-
}
101-
}
102-
}
103-
}
104-
}
105-
106-
@media (max-width: 968px) {
107-
.footer {
108-
.footer-content {
109-
grid-template-columns: 1fr;
110-
gap: 2rem;
111-
112-
.footer-links {
113-
grid-template-columns: repeat(2, 1fr);
114-
}
115-
}
116-
}
117-
}
118-
119-
@media (max-width: 576px) {
120-
.footer {
121-
padding: 2rem 1rem;
122-
123-
.footer-content {
124-
.footer-links {
125-
grid-template-columns: 1fr;
126-
}
127-
}
128-
129-
.footer-bottom {
130-
flex-direction: column;
131-
text-align: center;
132-
gap: 1rem;
133-
}
134-
}
135-
}

‎src/app/components/header/header.component.scss‎

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +0,0 @@
1-
.header {
2-
display: flex;
3-
justify-content: space-between;
4-
align-items: center;
5-
padding: 1rem 2rem;
6-
background: white;
7-
border-bottom: 1px solid #eee;
8-
9-
.logo {
10-
display: flex;
11-
align-items: center;
12-
gap: 0.5rem;
13-
font-weight: 500;
14-
15-
img {
16-
height: 32px;
17-
}
18-
}
19-
20-
nav {
21-
ul {
22-
display: flex;
23-
gap: 2rem;
24-
list-style: none;
25-
margin: 0;
26-
padding: 0;
27-
28-
a {
29-
color: #333;
30-
text-decoration: none;
31-
display: flex;
32-
align-items: center;
33-
gap: 0.25rem;
34-
35-
.dropdown-arrow {
36-
font-size: 0.8em;
37-
}
38-
39-
&:hover {
40-
color: #006F3C;
41-
}
42-
}
43-
}
44-
}
45-
}

‎src/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<head>
44
<meta charset="utf-8">
55
<meta name="viewport" content="width=device-width, initial-scale=1.0">
6-
<base href="/vf-angular/">
6+
<base href="/">
77
<link rel="stylesheet" media="all" href="https://dev.assets.emblstatic.net/vf/develop/css/styles.css"/>
88
<!--
99
Want to build a site with the Visual Framework?

0 commit comments

Comments
 (0)